Review main Merged

58550[BUGFIX] Ensure LoadTcaService loads ext_tables.php

Benni Mack CR +2 V +2 Easy +1 −1 updated 10/02/18, 06:27

Commit message

During deprecation of TYPO3_LOADED_EXT,
ext_tables.php is not loaded in "Check TCA in ext_tables.php"
anymore.

The fix loads the file correctly.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Benjamin Franzke +1
    • Josef Glatz +1
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Jigal van Hemert +2
    • Benjamin Franzke +1
    • Josef Glatz +1

Issues 1

Files 1

Review log 910

  1. Benni Mack uploaded patch set 1 10/02/18, 06:14

  2. Andreas Kienast voted on patch set 1 CR +1 10/02/18, 06:14

  3. Benjamin Franzke voted on patch set 1 CR +1 10/02/18, 06:15

  4. Wouter Wolters voted on patch set 1 CR +1 10/02/18, 06:15

  5. Josef Glatz voted on patch set 1 V +1 CR +1 10/02/18, 06:16

  6. Benjamin Franzke voted on patch set 1 V +1 10/02/18, 06:17

  7. Jigal van Hemert voted on patch set 1 V +2 CR +2 10/02/18, 06:20

  8. Benni Mack merged patch set 2 10/02/18, 06:21

  9. Benni Mack commented on patch set 2 10/02/18, 06:21

    ah, crap... where is this bamboo. sry
  10. TYPO3com voted on patch set 1 V +1 10/02/18, 06:27 Completed build in 13m 07s on Tue, 2 Oct, 08:27 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29252