Review main Merged

58552[BUGFIX] Do not append slashes on slug importer

Benni Mack CR +2 V +2 Easy +1 −1 updated 10/02/18, 06:49

Commit message

When importing from page_path of RealURL,
a slash is appended for all imported URLs,
however TYPO3 Core does not add slashes at the
end for new pages - which leads to a bad UX, having
mixed values.

However, with route enhancers, it is possible to add slashes
to the very end of a link, so it's useful to NOT have them
anymore inside the database.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Kevin Appelt +1
    • Andreas Kienast +1
    • Willi Wehmeier +1
  • Verified V +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Benni Mack uploaded patch set 1 10/02/18, 06:20

  2. Benni Mack updated the commit message in patch set 2 10/02/18, 06:20

  3. Kevin Appelt voted on patch set 2 CR +1 10/02/18, 06:25

  4. Georg Ringer voted on patch set 2 CR +1 10/02/18, 06:25

  5. Willi Wehmeier voted on patch set 2 CR +1 10/02/18, 06:26

  6. TYPO3com voted on patch set 1 V +1 10/02/18, 06:37 Completed build in 15m 18s on Tue, 2 Oct, 08:37 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29254

  7. TYPO3com voted on patch set 2 V +1 10/02/18, 06:41 Completed build in 20m 00s on Tue, 2 Oct, 08:41 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29255

  8. Andreas Kienast voted on patch set 2 CR +1 10/02/18, 06:43

  9. Andreas Kienast voted on patch set 2 V +1 10/02/18, 06:47

  10. Georg Ringer voted on patch set 2 V +2 CR +2 10/02/18, 06:48

  11. Georg Ringer merged patch set 3 10/02/18, 06:49