Review main Merged

58557[BUGFIX] Adjust conditions for Symfony Expressions in RST-files

Stefan Neufeind CR +2 V +2 Easy +9 −9 updated 10/03/18, 08:46

Commit message

Since the original introduction of some new features the syntax used
for the expression was adjusted globally in TYPO3, leading to
examples no longer up-to-date in the documentation shipped as RSTs.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Stefan Neufeind uploaded patch set 1 10/02/18, 08:41

  2. TYPO3com voted on patch set 1 V -1 10/02/18, 08:53 Completed build in 12m 16s on Tue, 2 Oct, 10:53 AM Test Summary: 3 of 38155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29269

  3. Georg Ringer rebased onto patch set 2 10/02/18, 12:17

  4. Georg Ringer voted on patch set 2 V +1 CR +1 10/02/18, 12:17

  5. TYPO3com voted on patch set 2 V -1 10/02/18, 12:31 Completed build in 14m 16s on Tue, 2 Oct, 02:31 PM Test Summary: 3 of 38155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29273

  6. Andreas Kienast rebased onto patch set 3 10/03/18, 06:36

  7. TYPO3com voted on patch set 3 V +1 10/03/18, 07:03 Completed build in 23m 15s on Wed, 3 Oct, 09:03 AM Test Summary: 37766 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29289

  8. Georg Ringer voted on patch set 3 V +1 CR +1 10/03/18, 07:53

  9. Benni Mack voted on patch set 3 V +2 CR +2 10/03/18, 08:46

  10. Benni Mack merged patch set 4 10/03/18, 08:46