Review main Merged

58558[BUGFIX] Return success when zero wizards run in upgrade:run

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 10/12/18, 07:31

Commit message

Having to run zero wizards (e.g. fully upgraded)
is obviously not an error.

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Tomas Norre Mikkelsen +1
    • Anja Leichsenring +1
  • Verified V +2
    • Mathias Brodala +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. Benjamin Franzke uploaded patch set 1 10/02/18, 12:15

  2. Wouter Wolters commented on patch set 1 10/02/18, 12:18

    we are not branched of yet, so only master is good enough here ;)
  3. TYPO3com voted on patch set 1 V -1 10/02/18, 12:28 Completed build in 13m 26s on Tue, 2 Oct, 02:28 PM Test Summary: 3 of 38155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29272

  4. Mathias Brodala updated the commit message in patch set 2 10/02/18, 12:29

  5. TYPO3com voted on patch set 2 V -1 10/02/18, 12:40 Completed build in 11m 19s on Tue, 2 Oct, 02:40 PM Test Summary: 3 of 38155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29274

  6. TYPO3com commented on patch set 2 10/02/18, 12:55 Completed build in 37m 50s on Tue, 2 Oct, 02:55 PM Test Summary: 3 of 38155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29274

  7. Mathias Brodala commented on patch set 2 10/02/18, 12:59

    Build fails due to text change in the introduction package.
  8. Andreas Kienast rebased onto patch set 3 10/03/18, 06:36

  9. TYPO3com voted on patch set 3 V +1 10/03/18, 06:58 Completed build in 18m 16s on Wed, 3 Oct, 08:58 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29288

  10. Tomas Norre Mikkelsen voted on patch set 3 CR +1 10/05/18, 18:53

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 10/11/18, 18:51

  12. Mathias Brodala voted on patch set 3 V +2 CR +2 10/12/18, 07:31

  13. Mathias Brodala merged patch set 4 10/12/18, 07:31