Review main Merged

58559[BUGFIX] Update installation acceptance tests

Mathias Brodala CR +2 V +2 Normal +72 −63 updated 10/05/18, 07:36

Commit message

The introduction package was revamped which brought us some text
changes, thus update the installation acceptance tests accordingly.

To mitigate an issue with certain databases causing a wrong casing of
column names, the DefaultTcaSchema now always quotes all column names
with backticks.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stephan Großberndt +1
    • Wouter Wolters +1
    • Andreas Kienast +1
    • Jörg Bösche +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1420

  1. Mathias Brodala uploaded patch set 1 10/02/18, 13:29

  2. TYPO3com voted on patch set 1 V -1 10/02/18, 13:41 Completed build in 11m 34s on Tue, 2 Oct, 03:41 PM Test Summary: 1 of 38153 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29275

  3. TYPO3com commented on patch set 1 10/02/18, 13:44 Completed build in 26m 46s on Tue, 2 Oct, 03:44 PM Test Summary: 1 of 38153 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29275

  4. Andreas Kienast uploaded patch set 2 10/02/18, 16:56

  5. TYPO3com voted on patch set 2 V -1 10/02/18, 17:08 Completed build in 11m 48s on Tue, 2 Oct, 07:08 PM Test Summary: 3 of 38152 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29279

  6. Andreas Kienast uploaded patch set 3 10/02/18, 17:09

  7. Andreas Kienast updated the commit message in patch set 4 10/02/18, 17:17

  8. Andreas Kienast voted on patch set 4 V +1 CR +1 10/02/18, 17:23

  9. TYPO3com voted on patch set 3 V +1 10/02/18, 17:23 Completed build in 13m 52s on Tue, 2 Oct, 07:23 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29280

  10. TYPO3com voted on patch set 4 V +1 10/02/18, 17:28 Completed build in 10m 39s on Tue, 2 Oct, 07:28 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29281

  11. Stephan Großberndt commented on patch set 4 10/02/18, 17:32

    DefaultTcaSchemaTest.php:485 Unresolved

    Maybe use rowDescription here to have that in tests too?
  12. Andreas Kienast uploaded patch set 5 10/02/18, 17:43

  13. Andreas Kienast voted on patch set 5 V +1 CR +1 10/02/18, 17:43

  14. TYPO3com voted on patch set 5 V +1 10/02/18, 17:55 Completed build in 11m 32s on Tue, 2 Oct, 07:55 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29282

  15. Wouter Wolters voted on patch set 5 V +1 CR +1 10/02/18, 18:22

  16. Stephan Großberndt voted on patch set 5 CR +1 10/02/18, 18:38

  17. Jörg Bösche voted on patch set 5 CR +1 10/02/18, 21:05

  18. Georg Ringer voted on patch set 5 V +2 CR +2 10/03/18, 06:16

  19. Georg Ringer merged patch set 6 10/03/18, 06:16

  20. Mathias Brodala commented on patch set 6 10/05/18, 07:36

    Thanks for the fix of the fix. :-)