Review main Merged

58563[BUGFIX] Use chr(10) instead of LF in functional test data provider

Christian Kuhn CR +2 V +2 Easy +7 −7 updated 10/03/18, 13:47

Commit message

The functional test splitter script does not define LF and various
other constants, but loads test data providers to find out how
many tests they produce. Those data provider should not use LF,
the splitter throws PHP warnings otherwise.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 10/03/18, 10:06

  2. Christian Kuhn commented on patch set 1 10/03/18, 10:08

    note the alternative is to make the splitter aware of the constants. however, i don't really want to define those in the splitter script or otherwise bootstrap core in any way. i thus decided to just drop the LF usages here, this solution shouldn't harm either ...
  3. TYPO3com voted on patch set 1 V +1 10/03/18, 10:17 Completed build in 11m 21s on Wed, 3 Oct, 12:17 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29294

  4. Oliver Klee voted on patch set 1 CR +1 10/03/18, 10:22

  5. Christian Kuhn commented on patch set 1 10/03/18, 13:17

    i'll merge that as de-facto no-brainer soon.
  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/03/18, 13:46

  7. Christian Kuhn merged patch set 2 10/03/18, 13:47