58565[BUGFIX] Only set renderType to hidden for overrideVals
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 34
-
Andreas Wolf uploaded patch set 1 10/03/18, 11:27
-
TYPO3com voted on patch set 1 V -1 10/03/18, 11:39 Completed build in 11m 13s on Wed, 3 Oct, 01:39 PM Test Summary: 3 of 38152 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29298
-
Christian Kuhn commented on patch set 1 CR -1 10/25/18, 14:03
we debugged around on this and think that approach is not a good idea: depending on the original type, this patch will lead to different value processing by the single-type data providers. we should avoid that. i general i don't like the 'type=hidden' approach in the first place, but that is nothing we can change right now. instead, we'll make the slug handler aware of 'sys_language_uid can be either a single value or an array' and will add the overrideVals if editing non-default page records from within the list module, too. this will both fix the bug and make the core more consistent in this regard. tl;dr: please abandon. -
Anja Leichsenring abandoned the change 10/25/18, 14:07
see comment by Christian above