Review main Merged

58571[BUGFIX] Fix path when writing AdditionalConfiguration.php

Alexander Stehlik CR +2 V +2 Easy +1 −1 updated 10/11/18, 10:04

Commit message

Use the getAdditionalConfigurationFileLocation() method to
determine the path to the file.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Tomas Norre Mikkelsen +1
    • Rune Piper +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Rune Piper +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Alexander Stehlik uploaded patch set 1 10/03/18, 19:09

  2. TYPO3com voted on patch set 1 V +1 10/03/18, 19:21 Completed build in 12m 07s on Wed, 3 Oct, 09:21 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29309

  3. Tomas Norre Mikkelsen voted on patch set 1 CR +1 10/06/18, 19:11

  4. Rune Piper voted on patch set 1 V +1 CR +1 10/11/18, 09:43

  5. Susi Moog voted on patch set 1 CR +1 10/11/18, 09:55

  6. Andreas Kienast voted on patch set 1 CR +1 10/11/18, 10:00

  7. Susi Moog voted on patch set 1 V +1 10/11/18, 10:02

  8. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 10/11/18, 10:04

  9. Tymoteusz Motylewski merged patch set 2 10/11/18, 10:04