Review main Merged

58572[BUGFIX] Add margin-bottom for tab-content

Nikita Hovratov CR +2 V +2 Easy +7 −2 updated 10/28/18, 14:32

Commit message

This adds a margin between the tab-content and the submit-button in the
extension configuration form.

Review

  • Code review CR +2
    • Benni Mack +2
    • Jürgen Heym +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Jürgen Heym +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1620

  1. Nikita Hovratov uploaded patch set 1 10/03/18, 19:10

  2. TYPO3com voted on patch set 1 V +1 10/03/18, 19:23 Completed build in 12m 58s on Wed, 3 Oct, 09:23 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29310

  3. Josef Glatz voted on patch set 1 V -1 CR -1 10/04/18, 20:49

  4. Josef Glatz commented on patch set 1 10/04/18, 20:57

    .tab-content is not only used in that context. I've searched for "tab-content" classes in the core and saw some not intended side effects which should not happen (e.g. formEngine Container).
  5. Josef Glatz commented on patch set 1 10/04/18, 20:58

    We need another solution here!
  6. Andreas Kienast commented on patch set 1 V -1 CR -1 10/05/18, 07:07

    This impacts any tab container in the whole backend.
  7. Nikita Hovratov uploaded patch set 2 10/05/18, 07:23

  8. TYPO3com voted on patch set 2 V +1 10/05/18, 07:36 Completed build in 12m 41s on Fri, 5 Oct, 09:36 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29329

  9. Josef Glatz commented on patch set 2 V +1 CR +1 10/05/18, 08:39

    _modal.scss:301

    AFAIK CSS classes beginning with t3js should basically not used to often for stylings. But I already found some areas where this approach was used in conjunction with modals. So I think that fits ツ
  10. Josef Glatz voted on patch set 2 V 0 CR 0 10/05/18, 08:41

  11. Andreas Kienast commented on patch set 2 CR -1 10/05/18, 08:41

    Will take a closer look at this. This is already the second quickfix for modals that affect the System Maintainer area only.
  12. Benni Mack uploaded patch set 3 10/27/18, 20:35

  13. TYPO3com voted on patch set 3 V +1 10/27/18, 20:48 Completed build in 13m 16s on Sat, 27 Oct, 10:48 PM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29701

  14. Oliver Hader uploaded patch set 4 10/27/18, 21:40

  15. TYPO3com voted on patch set 4 V +1 10/27/18, 21:55 Completed build in 14m 43s on Sat, 27 Oct, 11:55 PM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29712

  16. Susi Moog voted on patch set 4 V +1 CR +1 10/28/18, 09:13

  17. Benni Mack voted on patch set 4 V +2 CR +2 10/28/18, 10:12

  18. Benni Mack merged patch set 5 10/28/18, 10:12

  19. Jürgen Heym voted on patch set 5 V +1 CR +1 10/28/18, 11:01

  20. Christian Kuhn commented on patch set 5 10/28/18, 14:32

    _modal.scss:301

    this should have been gone to the install scss file i suppose.