Review main Merged

58573[BUGFIX] Display FlashMessage in View Module

Oli Bartsch CR +2 V +2 Normal +88 −45 updated 10/26/18, 14:49

Commit message

When clicking on the root page while in view module
a FlashMessage is now displayed with proper information.
The FlashMessage is also shown in the case of clicking the
root page and a Page, marked as siteroot, exists.
Furthermore the FlashMessage is now also shown if the
selected page has no valid doktype e.g. sysfolder
or spacer.

Review

  • Code review CR +2
    • Benni Mack +2
    • Joerg Kummer +1
    • Rudy Gnodde +1
  • Verified V +2
    • Benni Mack +2
    • Jasmina Ließmann +1
    • Joerg Kummer +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1520

  1. Oli Bartsch uploaded patch set 1 10/03/18, 20:02

  2. TYPO3com voted on patch set 1 V -1 10/03/18, 20:02 Completed build in 09s on Wed, 3 Oct, 10:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29313

  3. Oli Bartsch uploaded patch set 2 10/03/18, 20:13

  4. Josef Glatz commented on patch set 2 CR -1 10/03/18, 20:21

    Could you please add proper linebreaks? Take a look at the other commits. Thx ツ
  5. TYPO3com voted on patch set 2 V +1 10/03/18, 20:24 Completed build in 10m 29s on Wed, 3 Oct, 10:24 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29314

  6. Guido Schmechel commented on patch set 2 10/03/18, 20:39

    ViewModuleController.php:166

    Maybe we can also check here athe Doktype? So we can catch pages like folder or something else. What do you think?
  7. Oli Bartsch updated the commit message in patch set 3 10/03/18, 20:40

  8. Oli Bartsch commented on patch set 3 10/03/18, 20:47

    Reply

    Done

    ViewModuleController.php:166 Reply

    Yes this is a good idea. I also saw that if there is no Typoscript Template or there is a Template but no Page with typeNum=0 also an Exception is thrown. Should we check that too?
  9. TYPO3com voted on patch set 3 V +1 10/03/18, 20:51 Completed build in 10m 29s on Wed, 3 Oct, 10:51 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29316

  10. Oli Bartsch uploaded patch set 4 10/03/18, 21:32

  11. TYPO3com voted on patch set 4 V +1 10/03/18, 21:45 Completed build in 12m 31s on Wed, 3 Oct, 11:45 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29318

  12. Oli Bartsch commented on patch set 4 10/03/18, 21:53

    > Patch Set 3: > > (2 comments)

    ViewModuleController.php:166 Reply Unresolved

    Added the check for valid Doktype in the patch set 4.
  13. Benni Mack uploaded patch set 5 10/26/18, 14:03

  14. Benni Mack voted on patch set 5 V +1 CR +1 10/26/18, 14:03

  15. Rudy Gnodde voted on patch set 5 CR +1 10/26/18, 14:15

  16. TYPO3com voted on patch set 5 V +1 10/26/18, 14:20 Completed build in 16m 51s on Fri, 26 Oct, 04:20 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29603

  17. Jasmina Ließmann voted on patch set 5 V +1 10/26/18, 14:33

  18. Joerg Kummer voted on patch set 5 V +1 CR +1 10/26/18, 14:48

  19. Benni Mack voted on patch set 5 V +2 CR +2 10/26/18, 14:49

  20. Benni Mack merged patch set 6 10/26/18, 14:49