Review main Merged

58574[TASK] Add return type declaration to FileDumpController::dumpAction

Benjamin Franzke CR +2 V +2 Easy +2 −2 updated 10/04/18, 17:18

Commit message

For historical reasons FileDumpController::dumpAction was allowed to
return null. It didn't specify a nullable return type declaration because
it was not yed decided whether v9 will require php 7.2 or not.
With https://review.typo3.org/55585 FileDumpController was adapted to
return a PSR-7 Response but missed to update the function signature.
The nullable annotation is therefore removed now and the explicit
return type declaration is added.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benjamin Franzke uploaded patch set 1 10/03/18, 20:57

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 10/03/18, 20:58

  3. TYPO3com voted on patch set 1 V +1 10/03/18, 21:08 Completed build in 11m 32s on Wed, 3 Oct, 11:08 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29317

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/04/18, 17:18

  5. Benni Mack merged patch set 2 10/04/18, 17:18