Review main Merged

58577[BUGFIX] Fix version preview checks in PageRepository

Markus Klein CR +2 V +2 Easy +6 −6 updated 10/11/18, 07:45

Commit message

This patch corrects all conditions for version preview in the
PageRepository class, which have been converted incorrectly
with #85078.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Frank Nägler +1
    • Benni Mack +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Markus Klein uploaded patch set 1 10/04/18, 20:26

  2. TYPO3com voted on patch set 1 V +1 10/04/18, 20:36 Completed build in 10m 31s on Thu, 4 Oct, 10:36 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29327

  3. Frank Nägler commented on patch set 1 V +1 CR -1 10/05/18, 08:05

    that's my fix which works in my instance. Benni should also have a look please
  4. Benni Mack voted on patch set 1 CR +1 10/05/18, 11:23

  5. Frank Nägler voted on patch set 1 CR +1 10/08/18, 08:09

  6. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 10/11/18, 07:45

  7. Tymoteusz Motylewski merged patch set 2 10/11/18, 07:45