Review main Merged

58578[BUGFIX] Disable dump autoloading in Composer mode

Rune Piper CR +2 V +2 Easy +12 −3 updated 10/11/18, 12:11

Commit message

This patch hides the "Dump autoload" button in the maintenance area when
in Composer mode, because it does nothing.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Tomas Norre Mikkelsen +1
    • Tobi Kretschmann +1
    • Torben Hansen +1
    • Nikita Hovratov +1
  • Verified V +2
    • Frank Nägler +2
    • Tobi Kretschmann +1
    • Nikita Hovratov +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1417

  1. Rune Piper uploaded patch set 1 10/05/18, 07:21

  2. TYPO3com voted on patch set 1 V +1 10/05/18, 07:33 Completed build in 11m 44s on Fri, 5 Oct, 09:33 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29328

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/05/18, 07:33

  4. Rune Piper updated the commit message in patch set 2 10/05/18, 07:47

  5. Nikita Hovratov voted on patch set 2 V +1 CR +1 10/05/18, 07:59

  6. TYPO3com voted on patch set 2 V +1 10/05/18, 08:00 Completed build in 13m 00s on Fri, 5 Oct, 10:00 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29331

  7. Torben Hansen voted on patch set 2 CR +1 10/05/18, 08:26

  8. Josef Glatz updated the commit message in patch set 3 10/05/18, 08:30

  9. TYPO3com voted on patch set 3 V +1 10/05/18, 08:43 Completed build in 13m 12s on Fri, 5 Oct, 10:43 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29332

  10. Torben Hansen voted on patch set 3 CR +1 10/05/18, 08:47

  11. Nikita Hovratov voted on patch set 3 V +1 CR +1 10/05/18, 11:40

  12. Tomas Norre Mikkelsen voted on patch set 3 CR +1 10/05/18, 17:15

  13. Georg Ringer commented on patch set 3 10/06/18, 19:39

    question is: why display the setting at all? don't actually know myself
  14. Rune Piper commented on patch set 3 10/08/18, 05:31

    > question is: why display the setting at all? don't actually know > myself I haven't thought a lot about it, but not every maintainer may know, that you have to dump the autoloading via Composer.
  15. Tobi Kretschmann voted on patch set 3 V +1 CR +1 10/08/18, 14:00

  16. Frank Nägler voted on patch set 3 V +2 CR +2 10/11/18, 12:11

  17. Frank Nägler merged patch set 4 10/11/18, 12:11