Review main Merged

58579[BUGFIX] Initialize arguments correctly in routing related ViewHelpers

Daniel Goerz CR +2 V +2 Easy +42 −4 updated 10/08/18, 08:33

Commit message

Being initialized with the correct default value of an empty array
the Viewhelper no longer leads to a fatal error if called without
the argument "parameters".

Additionally the argument "route" is marked as required.

Review

  • Code review CR +2
    • Mathias Brodala +2
    • Josef Glatz +1
    • Rudy Gnodde +1
  • Verified V +2
    • Mathias Brodala +2
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1417

  1. Daniel Goerz uploaded patch set 1 10/05/18, 07:39

  2. TYPO3com voted on patch set 1 V +1 10/05/18, 07:50 Completed build in 10m 47s on Fri, 5 Oct, 09:50 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29330

  3. Mathias Brodala voted on patch set 1 CR +1 10/05/18, 07:58

  4. Jan Stockfisch voted on patch set 1 CR +1 10/05/18, 08:02

  5. Daniel Goerz commented on patch set 1 10/05/18, 08:10

    To verify, just copy the ViewHelper from the forge issue description to any backend module template.
  6. Anja Leichsenring commented on patch set 1 CR -1 10/05/18, 10:51

    those VHs have unit test files. It would be nice if you could add the fatal part and its fix into the tests.
  7. Daniel Goerz commented on patch set 1 10/05/18, 11:41

    Hi Anja, I thought about that, but the best I can come up with is to test that the new default is passed to the UriBuilder instead of the old one (null). The error happens in the UriBuilder if a non-array is passed as $parameters. I can add those test but IMO they dont really show anything but that the default changed ... And I do not wanted to touch the uribUilder itself in this patch, because the API is clear, only this VHs are using it wrong.
  8. Daniel Goerz uploaded patch set 2 10/05/18, 11:43

  9. Daniel Goerz uploaded patch set 3 10/05/18, 11:44

  10. TYPO3com voted on patch set 2 V +1 10/05/18, 11:55 Completed build in 11m 56s on Fri, 5 Oct, 01:55 PM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29335

  11. TYPO3com voted on patch set 3 V +1 10/05/18, 11:58 Completed build in 13m 38s on Fri, 5 Oct, 01:58 PM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29336

  12. Rudy Gnodde voted on patch set 3 CR +1 10/05/18, 12:34

  13. Josef Glatz voted on patch set 3 CR +1 10/08/18, 07:49

  14. Mathias Brodala commented on patch set 3 V +1 CR +1 10/08/18, 07:55

    Tested in the site config overview page.
  15. Josef Glatz voted on patch set 3 V +1 10/08/18, 08:01

  16. Mathias Brodala voted on patch set 3 V +2 CR +2 10/08/18, 08:33

  17. Mathias Brodala merged patch set 4 10/08/18, 08:33