Review main Merged

58582[BUGFIX] Do not cache content with different status code than 200

Markus Klein CR +2 V +2 Easy +5 −0 updated 04/19/19, 13:15

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Tomas Norre Mikkelsen +1
    • Johannes Kasberger +1
    • Andreas Kienast +1
  • Verified V +2
    • Georg Ringer +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1214

  1. Markus Klein uploaded patch set 1 10/05/18, 08:57

  2. Markus Klein uploaded patch set 2 10/05/18, 08:58

  3. TYPO3com voted on patch set 1 V +1 10/05/18, 09:10 Completed build in 12m 36s on Fri, 5 Oct, 11:10 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29333

  4. TYPO3com voted on patch set 2 V +1 10/05/18, 09:13 Completed build in 14m 29s on Fri, 5 Oct, 11:13 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29334

  5. Andreas Kienast voted on patch set 2 CR +1 10/05/18, 09:13

  6. Markus Klein commented on patch set 2 V -1 10/05/18, 09:41

    investigating something
  7. Markus Klein commented on patch set 2 V 0 10/05/18, 09:53

    all good
  8. Benni Mack voted on patch set 2 CR +2 10/05/18, 11:24

  9. Johannes Kasberger voted on patch set 2 V +1 CR +1 10/05/18, 12:31

  10. Tomas Norre Mikkelsen voted on patch set 2 CR +1 10/05/18, 18:55

  11. Stefan Neufeind voted on patch set 2 CR +1 10/10/18, 09:48

  12. Georg Ringer voted on patch set 2 V +2 10/10/18, 10:45

  13. Georg Ringer merged patch set 3 10/10/18, 10:45

  14. Helmut Hummel commented on patch set 3 04/19/19, 13:15

    I think this change here should rather be reverted. See my comments here: https://forge.typo3.org/issues/83755#note-11