58586[TASK] Use different placeholder than ###
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Daniel Goerz +1
- Tomas Norre Mikkelsen +1
- Jürgen Heym +1
- Tobi Kretschmann +1
- Jan Stockfisch +1
-
Verified V +2
- Benni Mack +2
- Jürgen Heym +1
- Tobi Kretschmann +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1820
-
Stefan Neufeind uploaded patch set 1 10/06/18, 16:35
-
Stefan Neufeind commented on patch set 1 10/06/18, 16:36
For 8.7 it's in sysext/core/Classes/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcher.php -
TYPO3com voted on patch set 1 V +1 10/06/18, 16:46 Completed build in 11m 06s on Sat, 6 Oct, 06:46 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29341
-
Tomas Norre Mikkelsen voted on patch set 1 CR +1 10/06/18, 19:13
-
Georg Ringer voted on patch set 1 V +1 CR +1 10/06/18, 19:26
-
Stefan Froemken voted on patch set 1 CR +1 10/07/18, 01:57
-
Benni Mack commented on patch set 1 10/07/18, 19:09
please also backport this to 7.6 -
Stefan Neufeind updated the commit message in patch set 2 10/07/18, 22:07
-
Stefan Neufeind commented on patch set 2 10/07/18, 22:07
please revote - just 7.6 added as well in the commit-msg -
TYPO3com voted on patch set 2 V +1 10/07/18, 22:18 Completed build in 10m 49s on Mon, 8 Oct, 12:18 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29351
-
Jan Stockfisch voted on patch set 2 CR +1 10/08/18, 12:17
-
Tobi Kretschmann commented on patch set 2 V +1 CR +1 10/08/18, 13:32
still works as expected -
Tomas Norre Mikkelsen commented on patch set 2 10/08/18, 13:34
Why is this Backported to 7.6? I thought the development of 7.6 was done.. And only security fixes for ELTS will be release.. Or am I getting something wrong ? -
Stefan Neufeind commented on patch set 2 10/08/18, 13:37
As requested by Benni, needed for PHP 7.3.0-compat. And imho it's just a minor tweak. Since Benni even suggested it himself I'm totally fine with that decision - low impact/risk, nice result :-) -
Benni Mack commented on patch set 2 10/08/18, 13:50
7.6 is not out of LTS phase yet, so only security + important bugfixes (until November 2018). If we can manage to have TYPO3 7.6 support PHP 7.3 that would be very favorable and important for the product. We aim to be as forward-upgradeaeble as possible. -
Tomas Norre Mikkelsen commented on patch set 2 CR +1 10/08/18, 13:57
To be clear, I'm not against it. Was just wondering, and under a different impression with the 7 LTS (ELTS) I'm perfectly fine with the decision. -
Daniel Goerz voted on patch set 2 CR +1 10/28/18, 13:04
-
Jürgen Heym voted on patch set 2 V +1 CR +1 10/28/18, 13:26
-
Benni Mack voted on patch set 2 V +2 CR +2 10/28/18, 13:34
-
Benni Mack merged patch set 3 10/28/18, 13:34