Review main Merged

58590[TASK] Do not render robots metatag on pages with index,follow

Richard Haeser CR +2 V +2 Easy +4 −2 updated 10/11/18, 06:58

Commit message

Index,follow is default behaviour for robots. In case that a page have
the index and follow attributes, the robots tag is not generated in
frontend.

Review

  • Code review CR +2
    • Markus Klein +2
    • Josef Glatz +1
    • Łukasz Uznański +1
    • Jörg Bösche +1
    • Marc Hirdes +1
  • Verified V +2
    • Markus Klein +2
    • Josef Glatz +1
    • Riccardo De Contardi +1
    • Łukasz Uznański +1
    • Jörg Bösche +1
    • Marc Hirdes +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1618

  1. Richard Haeser uploaded patch set 1 10/06/18, 19:18

  2. Riccardo De Contardi voted on patch set 1 V +1 10/06/18, 19:22

  3. TYPO3com voted on patch set 1 V +1 10/06/18, 19:32 Completed build in 13m 53s on Sat, 6 Oct, 09:32 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29346

  4. Christian Knauf voted on patch set 1 V +1 10/06/18, 19:40

  5. Josef Glatz voted on patch set 1 V +1 CR +1 10/07/18, 20:46

  6. Marc Hirdes voted on patch set 1 V +1 CR +1 10/08/18, 06:30

  7. Jörg Bösche voted on patch set 1 V +1 CR +1 10/09/18, 09:40

  8. Georg Ringer commented on patch set 1 10/09/18, 10:22

    MetaTagGenerator.php:116

    so why not working with $noIndex and compare that to its values, IMO better reading
  9. Richard Haeser uploaded patch set 2 10/10/18, 19:41

  10. TYPO3com voted on patch set 2 V +1 10/10/18, 19:54 Completed build in 13m 21s on Wed, 10 Oct, 09:54 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29401

  11. Riccardo De Contardi voted on patch set 2 V +1 10/10/18, 20:28

  12. Markus Klein voted on patch set 2 V +1 CR +1 10/10/18, 21:04

  13. Łukasz Uznański voted on patch set 2 V +1 CR +1 10/10/18, 21:53

  14. Josef Glatz voted on patch set 2 V +1 CR +1 10/11/18, 02:49

  15. Marc Hirdes voted on patch set 2 V +1 CR +1 10/11/18, 06:40

  16. Jörg Bösche voted on patch set 2 V +1 CR +1 10/11/18, 06:46

  17. Markus Klein voted on patch set 2 V +2 CR +2 10/11/18, 06:58

  18. Markus Klein merged patch set 3 10/11/18, 06:58