Review main Abandoned

58592[FEATURE] Add possibility to hide site title from the title tag

Richard Haeser CR 0 V 0 Normal +64 −4 updated 10/29/18, 08:02

Commit message

To prevent people using config.noPageTitle = 2 only to hide the site title,
there is a new option config.hideSiteTitle.

This option will hide the Website title from the generated title tag.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 2225

  1. Richard Haeser uploaded patch set 1 10/06/18, 19:33

  2. TYPO3com voted on patch set 1 V +1 10/06/18, 19:46 Completed build in 12m 39s on Sat, 6 Oct, 09:46 PM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29348

  3. Josef Glatz commented on patch set 1 10/07/18, 20:51

    Should that be documentated as this will differ from initial 9.5.0 release?
  4. Richard Haeser commented on patch set 1 10/14/18, 12:10

    Well, this not really differs from initial release. This only gives you more possibilities. And this should definetely be added to https://docs.typo3.org/typo3cms/CoreApiReference/ApiOverview/PageTitleApi/Index.html.
  5. Richard Haeser uploaded patch set 2 10/14/18, 17:15

  6. TYPO3com voted on patch set 2 V +1 10/14/18, 17:26 Completed build in 10m 39s on Sun, 14 Oct, 07:26 PM Test Summary: 37810 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29449

  7. Marc Hirdes voted on patch set 2 CR +1 10/15/18, 07:05

  8. Stefan Neufeind commented on patch set 2 CR +1 10/15/18, 07:41

    @Benni: Looks like a valid requirement to me. Fine to add this "missing boolean", as a "task"?
  9. Riny van Tiggelen voted on patch set 2 CR +1 10/16/18, 13:13

  10. Willi Wehmeier voted on patch set 2 CR +1 10/19/18, 05:59

  11. Joerg Kummer commented on patch set 2 10/25/18, 09:49

    Does introduction of a new configuration variable require feature-documentation?
  12. Jürgen Heym voted on patch set 2 V +1 CR +1 10/26/18, 13:22

  13. Oliver Hader commented on patch set 2 10/26/18, 13:37

    Basically fine with me to keep that as a task for v9.5 (even if it is a feature). However, proper documentation is missing - so please add an according feature RST file.
  14. Oliver Hader voted on patch set 2 CR +1 10/26/18, 13:37

  15. Richard Haeser commented on patch set 2 10/26/18, 13:38

    > Basically fine with me to keep that as a task for v9.5 (even if it > is a feature). > However, proper documentation is missing - so please add an > according feature RST file. RST on the way!
  16. Oliver Hader voted on patch set 2 V +1 10/26/18, 13:47

  17. Richard Haeser uploaded patch set 3 10/26/18, 13:57

  18. Jürgen Heym voted on patch set 3 V +1 CR +1 10/26/18, 14:09

  19. TYPO3com voted on patch set 3 V +1 10/26/18, 14:12 Completed build in 14m 30s on Fri, 26 Oct, 04:12 PM Test Summary: 37828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29602

  20. Joerg Kummer voted on patch set 3 V +1 CR +1 10/26/18, 14:34

  21. Stefan Neufeind voted on patch set 3 CR +1 10/26/18, 15:00

  22. Benni Mack commented on patch set 3 CR -2 10/28/18, 14:58

    I highly disagree with that change. The correct fix is NOT to set any kind of TypoScript option but to actually just remove the website title from sys_template - which is a simple fix and doable custom per site.
  23. Benni Mack voted on patch set 3 CR -1 10/28/18, 15:03

  24. Richard Haeser abandoned the change 10/28/18, 15:06

    As discussed with Benni, we will abandon this change. Just don't set the site title in your template record if you don't want it to show up in your title tag.
  25. Marc Hirdes commented on patch set 3 10/29/18, 08:02

    In my opinion this is not very flexible. I agree, that there is no need for a TypoScript option in general. Than you can really leave the site title. But in the Page Title Provider there should be an option to say, that this title is final. This would be great.