58595[BUGFIX] Always provide an array to applyControllerActionValues
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Tymoteusz Motylewski +1
- Susi Moog +1
-
Verified V +2
- Stefan Neufeind +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1418
-
Daniel Siepmann uploaded patch set 1 10/08/18, 08:09
-
TYPO3com voted on patch set 1 V +1 10/08/18, 08:20 Completed build in 10m 57s on Mon, 8 Oct, 10:20 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29357
-
Josef Glatz commented on patch set 1 10/08/18, 09:49
AFAIK you only need "master" as there is no new branch for v10 ツ -
Daniel Siepmann updated the commit message in patch set 2 10/08/18, 11:11
-
Daniel Siepmann updated the commit message in patch set 3 10/08/18, 11:11
-
TYPO3com voted on patch set 2 V +1 10/08/18, 11:22 Completed build in 11m 47s on Mon, 8 Oct, 01:22 PM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29359
-
TYPO3com voted on patch set 3 V +1 10/08/18, 11:25 Completed build in 13m 44s on Mon, 8 Oct, 01:25 PM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29360
-
Tymoteusz Motylewski commented on patch set 3 10/08/18, 13:09
maybe "[BUGFIX] Always provide an array to applyControllerActionValues" ? -
Daniel Siepmann updated the commit message in patch set 4 10/08/18, 14:57
-
Daniel Siepmann commented on patch set 3 10/08/18, 14:57
Reply
Done -
Josef Glatz wrote 10/08/18, 15:01
Removed reviewer Josef Glatz. -
TYPO3com voted on patch set 4 V +1 10/08/18, 15:09 Completed build in 12m 01s on Mon, 8 Oct, 05:09 PM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29362
-
Tymoteusz Motylewski voted on patch set 4 CR +1 10/11/18, 07:47
-
Anja Leichsenring commented on patch set 4 10/11/18, 18:44
I prefer an is_array check and only if this comes back as false, provide an empty array. -
Susi Moog commented on patch set 4 V +1 CR +1 10/13/18, 11:10
@Anja: I prefer it like this as: "not set" is fine, it's ok as a state and we should handle that "set to something that's not an array" is an actual error and should result in an error of the application if you want to secure that, check is array and empty and throw an exception for other data types, but that would be overkill here. -
Stefan Neufeind voted on patch set 4 V +1 CR +1 10/13/18, 11:19
-
Stefan Neufeind commented on patch set 4 V +2 CR +2 10/13/18, 19:32
talked to Anja about it -
Stefan Neufeind merged patch set 5 10/13/18, 19:32