Review main Merged

58596[BUGFIX] Prevent null value being passed to hash_equals

Sascha Egerer CR +2 V +2 Easy +5 −3 updated 10/26/18, 13:37

Commit message

The second parameter of hash_equals must be a string but could be a
null value in the FileDumpController. It is ensured now that the
value is always a string.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • Mathias Brodala +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1317

  1. Sascha Egerer uploaded patch set 1 10/08/18, 23:17

  2. TYPO3com voted on patch set 1 V +1 10/08/18, 23:28 Completed build in 10m 57s on Tue, 9 Oct, 01:28 AM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29363

  3. Mathias Brodala commented on patch set 1 10/09/18, 07:16

    FileDumpController.php:57

    I'd prefer to cast this to string instead to avoid unexpected side effects.
  4. Sascha Egerer commented on patch set 1 10/09/18, 08:50

    FileDumpController.php:57 Reply

    That was also my first version but then i thought it's an protected method of the class that is used nowhere else and is not public api. And as far as i could see the return value of getGetOrPost is a string anyways. So maybe the string cast could also be removed but i would keep it there to ensure it is a string.
  5. Mathias Brodala commented on patch set 1 10/09/18, 09:02

    FileDumpController.php:57 Reply

    Then you should at least declare strict types in this file and add parameter/return type hints.
  6. Sascha Egerer rebased onto patch set 2 10/09/18, 09:12

  7. Sascha Egerer uploaded patch set 3 10/09/18, 09:12

  8. TYPO3com commented on patch set 2 10/09/18, 09:24 Completed build in 12m 01s on Tue, 9 Oct, 11:24 AM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29367

  9. TYPO3com voted on patch set 3 V +1 10/09/18, 09:25 Completed build in 12m 44s on Tue, 9 Oct, 11:25 AM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29368

  10. Sascha Egerer updated the commit message in patch set 4 10/09/18, 09:27

  11. TYPO3com voted on patch set 4 V +1 10/09/18, 09:38 Completed build in 10m 53s on Tue, 9 Oct, 11:38 AM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29369

  12. Mathias Brodala voted on patch set 4 CR +1 10/09/18, 10:02

  13. Anja Leichsenring voted on patch set 4 V +1 CR +1 10/11/18, 18:45

  14. Andreas Kienast voted on patch set 4 V +1 CR +1 10/13/18, 08:30

  15. Oliver Klee voted on patch set 4 CR +1 10/13/18, 11:28

  16. Benni Mack voted on patch set 4 V +2 CR +2 10/26/18, 13:37

  17. Benni Mack merged patch set 5 10/26/18, 13:37