Review main Merged

58597[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself

Josef Glatz CR +2 V +2 Easy +6 −0 updated 10/11/18, 09:54

Commit message

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

In addition, the suggest has been improved to search also in the
following fields of page records:
* nav_title
* alias
* url

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Georg Ringer +1
    • Christian Kuhn +1

Issues 2

Files 1

Review log 2426

Show 1 earlier messages
  1. Josef Glatz uploaded patch set 1 10/09/18, 03:52

  1. TYPO3com voted on patch set 1 V +1 10/09/18, 04:03 Completed build in 11m 26s on Tue, 9 Oct, 06:03 AM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29364

  2. Richard Haeser voted on patch set 1 CR +1 10/09/18, 05:07

  3. Andreas Kienast voted on patch set 1 CR +1 10/09/18, 05:58

  4. Volker Kemeter voted on patch set 1 CR +1 10/09/18, 07:02

  5. Jörg Bösche voted on patch set 1 CR +1 10/09/18, 07:05

  6. Riny van Tiggelen voted on patch set 1 V +1 CR +1 10/09/18, 07:26

  7. Georg Ringer commented on patch set 1 CR +1 10/09/18, 07:34

    pages.php:643

    this should be a seperate issue or at least mentioned in the commit msg which should something be like "Improve suggest of field xyz
  8. Josef Glatz updated the commit message in patch set 2 10/09/18, 07:39

  9. TYPO3com voted on patch set 2 V +1 10/09/18, 07:50 Completed build in 10m 53s on Tue, 9 Oct, 09:50 AM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29366

  10. Jan Helke voted on patch set 2 V +1 CR +1 10/09/18, 08:37

  11. Andreas Kienast voted on patch set 2 CR +1 10/09/18, 08:52

  12. Jörg Bösche voted on patch set 2 CR +1 10/09/18, 09:37

  13. Christian Kuhn commented on patch set 2 10/09/18, 10:45

    pages.php:644

    this needs the doctrine identifier quoting, does it?
  14. Josef Glatz commented on patch set 2 V -1 CR -1 10/09/18, 11:34

  15. Josef Glatz rebased onto patch set 3 10/10/18, 04:06

  16. Josef Glatz commented on patch set 3 10/10/18, 05:06

    > (1 comment) Hey loli, as already written in DM, I think addWhere is excluded from the quoting or I'm wrong. Actually 500 is thrown if I quote addWhere like 'addWhere' => ' AND {#pages}.{#uid} != ###THIS_UID###' or 'addWhere' => ' AND {#pages}.{#uid} != \'###THIS_UID###\'' I would be glad if you could help me with the correct syntax
  17. Josef Glatz commented on patch set 3 10/10/18, 05:07

    Here's the DB query of my first attempt in my last comment: An exception occurred while executing 'SELECT * FROM `pages` WHERE (1=1) AND (`sys_language_uid` = 0) AND ({#pages}.{#uid} != 294) AND (`uid` = 142) AND ((`pages`.`deleted` = 0) AND ((`pages`.`t3ver_wsid` = 0) OR (`pages`.`t3ver_state` <= 0))) ORDER BY `title` ASC LIMIT 50 OFFSET 0'
  18. Andreas Kienast commented on patch set 3 10/10/18, 05:58

    > Patch Set 3: > > I would be glad if you could help me with the correct syntax I'm not lolli, but I can try ;) It seems suggestOptions/X/addWhere is indeed not supported, please see typo3/sysext/core/Classes/Preparations/TcaPreparation.php
  19. Josef Glatz commented on patch set 3 10/10/18, 07:08

    > > Patch Set 3: > > > > I would be glad if you could help me with the correct syntax > > I'm not lolli, but I can try ;) > > It seems suggestOptions/X/addWhere is indeed not supported, please > see typo3/sysext/core/Classes/Preparations/TcaPreparation.php should this be extended? (TcaPreparation) As this is out of scope of this patch, I'm fine if we wait or just adopt it later when TcaPreparation is extended/fixed
  20. Christian Kuhn commented on patch set 3 10/10/18, 13:58

    yeah. i think we should have a pre-patch to make TcaPreparation understand this.
  21. Georg Ringer voted on patch set 3 V +1 CR +1 10/10/18, 18:35

  22. Christian Kuhn commented on patch set 3 V +1 CR +1 10/11/18, 09:51

    ok, the tcaPreparation may need additional time. thus, I'd vote to merge this one here already and have adapt the sql fragment later again.
  23. Tymoteusz Motylewski voted on patch set 3 V +2 CR +2 10/11/18, 09:53

  24. Tymoteusz Motylewski merged patch set 4 10/11/18, 09:53

  25. Tymoteusz Motylewski commented on patch set 4 10/11/18, 09:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 641e7795cf17b1db7b1f9a251761358839626d1f