Review main Merged

58598[BUGFIX] Records sitemap uses wrong data array

Susi Moog CR +2 V +2 Normal +144 −1 updated 10/09/18, 12:02

Commit message

The records sitemap has an additional level of nesting for
data from database but was trying to access database data
on the first level resulting in missing URL parameters in
generated URLs.

This array access has been fixed.

Review

  • Code review CR +2
    • Markus Klein +2
    • Richard Haeser +1
  • Verified V +2
    • Markus Klein +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 911

  1. Susi Moog uploaded patch set 1 10/09/18, 10:14

  2. Georg Ringer voted on patch set 1 CR +1 10/09/18, 10:20

  3. TYPO3com voted on patch set 1 V +1 10/09/18, 10:24 Completed build in 10m 40s on Tue, 9 Oct, 12:24 PM Test Summary: 37798 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29371

  4. Susi Moog commented on patch set 1 CR -1 10/09/18, 10:49

    trying to come up with a test.
  5. Richard Haeser voted on patch set 1 V +1 CR +1 10/09/18, 10:50

  6. Susi Moog uploaded patch set 2 10/09/18, 11:16

  7. Richard Haeser voted on patch set 2 V +1 CR +1 10/09/18, 11:20

  8. TYPO3com voted on patch set 2 V +1 10/09/18, 11:27 Completed build in 11m 34s on Tue, 9 Oct, 01:27 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29372

  9. Markus Klein voted on patch set 2 V +1 CR +1 10/09/18, 12:02

  10. Markus Klein voted on patch set 2 V +2 CR +2 10/09/18, 12:02

  11. Markus Klein merged patch set 3 10/09/18, 12:02