58600[TASK] Remove canonical link if noindex
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Joerg Kummer +1
- Richard Haeser +1
- Felix Althaus +1
-
Verified V +2
- Benni Mack +2
- Joerg Kummer +1
- Richard Haeser +1
- Felix Althaus +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2631
Show 56 earlier messages
-
Gianluigi Martino uploaded patch set 1 10/09/18, 11:46
-
TYPO3com voted on patch set 1 V -1 10/09/18, 11:58 Completed build in 11m 41s on Tue, 9 Oct, 01:58 PM Test Summary: 10 of 38158 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29374
-
Marc Hirdes voted on patch set 1 CR +1 10/10/18, 07:18
-
Richard Haeser commented on patch set 1 CR -1 10/10/18, 08:48
I want to check both solutions before this is merged. -
Frank Nägler commented on patch set 1 CR -2 10/10/18, 08:50
temporary blocked, I am in contact with Richard about the issue -
Richard Haeser commented on patch set 1 10/10/18, 19:50
CanonicalGenerator.php:83I would like to remove these changes in this patch because this is not for the mentioned issue and for that issue there is already another pending patch. See https://review.typo3.org/#/c/58588/pages.php:203Can you move opengraph and twittercards pallettes to a new tab called "Social media"?
-
Frank Nägler voted on patch set 1 CR 0 10/10/18, 19:54
-
Richard Haeser commented on patch set 1 10/10/18, 20:11
Please also mention issue #86514 that will be solved with my latest comments. -
Gianluigi Martino uploaded patch set 2 10/11/18, 10:19
-
TYPO3com voted on patch set 2 V +1 10/11/18, 10:33 Completed build in 14m 06s on Thu, 11 Oct, 12:33 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29416
-
Richard Haeser commented on patch set 2 10/13/18, 12:01
CanonicalGenerator.php:104I would not do this in this patch. We have patch 58588 for that. -
Gianluigi Martino uploaded patch set 3 10/14/18, 09:13
-
TYPO3com voted on patch set 3 V +1 10/14/18, 09:26 Completed build in 12m 09s on Sun, 14 Oct, 11:25 AM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29448
-
Richard Haeser voted on patch set 3 V +1 CR +1 10/14/18, 09:34
-
Marc Hirdes voted on patch set 3 CR +1 10/15/18, 07:04
-
Jörg Bösche voted on patch set 3 V +1 CR +1 10/18/18, 14:29
-
Willi Wehmeier voted on patch set 3 CR +1 10/19/18, 05:52
-
Daniel Goerz voted on patch set 3 V +1 CR +1 10/26/18, 10:35
-
Daniel Goerz commented on patch set 3 V -1 CR -1 10/28/18, 08:44
The new SocialMedia tab was merged in a different patch: https://review.typo3.org/#/c/58718/. Please adjust this one to not also do that. -
Gianluigi Martino uploaded patch set 4 10/28/18, 08:56
-
TYPO3com voted on patch set 4 V +1 10/28/18, 09:10 Completed build in 13m 09s on Sun, 28 Oct, 10:10 AM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29714
-
Joerg Kummer commented on patch set 4 CR -1 10/28/18, 10:03
Se my comment, otherwise looks good and will be verified from my sidelocallang_tca.xlf:12This label is already part of this file with same value. See bottom line 64 -
Gianluigi Martino commented on patch set 5 10/28/18, 11:24
Published edit on patch set 4. -
TYPO3com voted on patch set 5 V +1 10/28/18, 11:39 Completed build in 15m 23s on Sun, 28 Oct, 12:39 PM Test Summary: 37843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29736
-
Joerg Kummer voted on patch set 5 V +1 CR +1 10/28/18, 11:55
-
Richard Haeser commented on patch set 5 10/28/18, 12:23
pages.php:202Why are those two separate addToAllTCAtypes now combined again? -
Felix Althaus voted on patch set 5 V +1 CR +1 10/28/18, 12:37
-
Joerg Kummer commented on patch set 5 10/28/18, 13:10
pages.php:202ReplyI think its fine. More readable, and one method call less. -
Richard Haeser commented on patch set 5 V +1 CR +1 10/28/18, 13:15
pages.php:202ReplyI think it is more readable as well ( I added the original code ). I guess we missed this change in the patch of earlier this week that had separated those two tabs. -
Benni Mack voted on patch set 5 V +2 CR +2 10/28/18, 13:15
-
Benni Mack merged patch set 6 10/28/18, 13:15