Review main Merged

58608[TASK] Split FormEngine.js

Andreas Kienast CR +2 V +2 Expert +925 −393 updated 03/14/19, 08:03

Commit message

This patch splits the FormEngine.js into smaller, logically separated
parts. This increases readability and maintainability and has a positive
effect on the client's performance as only the required code is loaded.

Not every aspect of the FormEngine JavaScript is handled here yet, since
other areas, e.g. IRRE, need refactoring as well.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • André Buchmann +1
    • Susi Moog +1
  • Verified V +2 Done
    • Frank Nägler +2
    • André Buchmann +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 34

Show 14 more files

Review log 2849

Show 1224 earlier messages
  1. Andreas Kienast uploaded patch set 1 10/10/18, 17:41

  2. TYPO3com voted on patch set 1 V +1 10/10/18, 17:53 Completed build in 12m 07s on Wed, 10 Oct, 07:53 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29397

  3. Andreas Kienast uploaded patch set 2 10/10/18, 18:02

  4. TYPO3com voted on patch set 2 V +1 10/10/18, 18:13 Completed build in 10m 34s on Wed, 10 Oct, 08:13 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29399

  5. Andreas Kienast uploaded patch set 3 10/11/18, 06:16

  6. TYPO3com voted on patch set 3 V +1 10/11/18, 06:28 Completed build in 11m 58s on Thu, 11 Oct, 08:28 AM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29407

  7. Mathias Schreiber updated the commit message in patch set 4 10/12/18, 06:51

  8. TYPO3com voted on patch set 4 V +1 10/12/18, 07:03 Completed build in 11m 32s on Fri, 12 Oct, 09:03 AM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29431

  9. Andreas Kienast uploaded patch set 5 11/02/18, 08:35

  10. TYPO3com voted on patch set 5 V +1 11/02/18, 08:46 Completed build in 10m 17s on Fri, 2 Nov, 09:46 AM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29942

  11. Andreas Kienast uploaded patch set 6 11/18/18, 20:30

  12. TYPO3com voted on patch set 6 V +1 11/18/18, 20:40 Completed build in 10m 18s on Sun, 18 Nov, 09:40 PM Test Summary: 48480 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30190

  13. Andreas Kienast rebased onto patch set 7 12/07/18, 19:06

  14. Andreas Kienast uploaded patch set 8 12/07/18, 19:06

  15. TYPO3com voted on patch set 7 V -1 12/07/18, 19:06 Completed build in 10s on Fri, 7 Dec, 08:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30516

  16. TYPO3com voted on patch set 8 V -1 12/07/18, 19:06 Completed build in 10s on Fri, 7 Dec, 08:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30517

  17. Andreas Kienast rebased onto patch set 9 12/07/18, 19:07

  18. TYPO3com voted on patch set 9 V +1 12/07/18, 19:22 Completed build in 15m 21s on Fri, 7 Dec, 08:22 PM Test Summary: 48576 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30518

  19. Andreas Kienast uploaded patch set 10 12/21/18, 22:42

  20. TYPO3com voted on patch set 10 V +1 12/21/18, 22:52 Completed build in 09m 45s on Fri, 21 Dec, 11:52 PM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31053

  21. Andreas Kienast uploaded patch set 11 12/21/18, 23:20

  22. TYPO3com voted on patch set 11 V +1 12/21/18, 23:31 Completed build in 10m 30s on Sat, 22 Dec, 12:31 AM Test Summary: 48176 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31055

  23. Andreas Kienast uploaded patch set 12 01/01/19, 19:02

  24. TYPO3com voted on patch set 12 V +1 01/01/19, 19:12 Completed build in 10m 22s on Tue, 1 Jan, 08:12 PM Test Summary: 47817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31182

  1. Andreas Kienast uploaded patch set 13 01/01/19, 21:02

  2. TYPO3com voted on patch set 13 V +1 01/01/19, 21:12 Completed build in 09m 33s on Tue, 1 Jan, 10:12 PM Test Summary: 47833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31184

  3. Andreas Kienast uploaded patch set 14 01/01/19, 21:42

  4. TYPO3com voted on patch set 14 V +1 01/01/19, 21:51 Completed build in 09m 22s on Tue, 1 Jan, 10:51 PM Test Summary: 47833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31185

  5. Andreas Kienast uploaded patch set 15 01/01/19, 22:39

  6. TYPO3com voted on patch set 15 V -1 01/01/19, 22:48 Completed build in 09m 23s on Tue, 1 Jan, 11:48 PM Test Summary: 2 of 48244 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31186

  7. Andreas Kienast uploaded patch set 16 01/02/19, 13:19

  8. TYPO3com voted on patch set 16 V +1 01/02/19, 13:29 Completed build in 09m 58s on Wed, 2 Jan, 02:29 PM Test Summary: 47833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31188

  9. Andreas Kienast commented on patch set 16 01/03/19, 15:27

    Will revert the deprecations here. The legacy methods should become deprecated all at once.
  10. Andreas Kienast uploaded patch set 17 01/03/19, 15:29

  11. TYPO3com voted on patch set 17 V +1 01/03/19, 15:38 Completed build in 09m 49s on Thu, 3 Jan, 04:38 PM Test Summary: 47833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31193

  12. Andreas Kienast uploaded patch set 18 01/03/19, 16:19

  13. TYPO3com voted on patch set 18 V +1 01/03/19, 16:30 Completed build in 11m 04s on Thu, 3 Jan, 05:30 PM Test Summary: 47833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31194

  14. Andreas Kienast uploaded patch set 19 01/03/19, 17:43

  15. TYPO3com voted on patch set 19 V +1 01/03/19, 17:54 Completed build in 10m 20s on Thu, 3 Jan, 06:54 PM Test Summary: 47833 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31195

  16. Andreas Kienast rebased onto patch set 20 01/09/19, 18:38

  17. TYPO3com voted on patch set 20 V +1 01/09/19, 18:50 Completed build in 11m 30s on Wed, 9 Jan, 07:50 PM Test Summary: 47625 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31381

  18. Andreas Kienast rebased onto patch set 21 01/15/19, 06:20

  19. TYPO3com voted on patch set 21 V +1 01/15/19, 06:33 Completed build in 12m 32s on Tue, 15 Jan, 07:33 AM Test Summary: 47584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31499

  20. André Buchmann voted on patch set 21 V +1 CR +1 02/01/19, 18:19

  21. Frank Nägler voted on patch set 21 CR +1 03/08/19, 22:40

  22. Frank Nägler voted on patch set 21 V +1 03/08/19, 22:51

  23. Susi Moog voted on patch set 21 V +1 CR +1 03/14/19, 08:01

  24. Frank Nägler voted on patch set 21 V +2 CR +2 03/14/19, 08:03

  25. Frank Nägler merged patch set 22 03/14/19, 08:03