Review main Merged

58609[BUGFIX] Avoid using hardcoded uid of repository record

Georg Ringer CR +2 V +2 Easy +2 −5 updated 10/11/18, 06:27

Commit message

As some situations might lead to a different uid set in the database
the correct repository should be found by the method 'findOneTypo3OrgRepository'.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Josef Glatz +1
    • Tomas Norre Mikkelsen +1
    • Markus Klein +1
    • Nicole Hummel +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 78

  1. Georg Ringer uploaded patch set 1 10/10/18, 19:34

  2. TYPO3com voted on patch set 1 V +1 10/10/18, 19:48 Completed build in 13m 17s on Wed, 10 Oct, 09:48 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29400

  3. Nicole Hummel commented on patch set 1 CR +1 10/10/18, 20:00

    I would opt to even merge this back to 8.7
  4. Markus Klein voted on patch set 1 V +1 CR +1 10/10/18, 20:52

  5. Josef Glatz voted on patch set 1 CR +1 10/11/18, 03:28

  6. Tomas Norre Mikkelsen voted on patch set 1 CR +1 10/11/18, 05:14

  7. Stefan Neufeind voted on patch set 1 V +2 CR +2 10/11/18, 06:27

  8. Stefan Neufeind merged patch set 2 10/11/18, 06:27