Review main Merged

58612[BUGFIX] Skip language -1 in preview url generation

Georg Ringer CR +2 V +2 Easy +4 −1 updated 11/08/18, 20:21

Commit message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Alexander Grein +1
    • Raphael Graf +1
  • Verified V +2
    • Anja Leichsenring +2
    • Alexander Grein +1
    • Raphael Graf +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Georg Ringer uploaded patch set 1 10/11/18, 06:49

  2. Stefan Neufeind commented on patch set 1 CR +1 10/11/18, 07:00

    typo
  3. TYPO3com voted on patch set 1 V +1 10/11/18, 07:00 Completed build in 10m 45s on Thu, 11 Oct, 09:00 AM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29410

  4. Anja Leichsenring updated the commit message in patch set 2 10/11/18, 18:53

  5. TYPO3com voted on patch set 2 V +1 10/11/18, 19:05 Completed build in 11m 07s on Thu, 11 Oct, 09:05 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29428

  6. Anja Leichsenring commented on patch set 2 V -1 10/11/18, 19:06

    in List View, after having set up like in the ticket, I can choose Lang -1 still for the tt_content record (no matter what language it is translated into or being default language). The field is sys_language_uid, if that helps.
  7. Georg Ringer commented on patch set 2 10/11/18, 19:47

    it is not about possible choosing -1 or not but about not breaking the UI if a user does choose the -1
  8. Alexander Grein commented on patch set 2 V -1 10/11/18, 19:48

    The exception is gone, but the element is not visible in the frontend
  9. Georg Ringer commented on patch set 2 10/11/18, 20:20

    FE is not part of this issue/fix
  10. Anja Leichsenring commented on patch set 2 10/13/18, 07:54

    > Patch Set 2: > > it is not about possible choosing -1 or not but about not breaking the UI if a user does choose the -1 it breaks already while choosing. (1/1) #1522960188 InvalidArgumentException Language -1 does not exist on site root. one will never reach the preview.
  11. Anja Leichsenring commented on patch set 2 10/13/18, 07:55

    > Patch Set 2: > > > Patch Set 2: > > > > it is not about possible choosing -1 or not but about not breaking the UI if a user does choose the -1 > > it breaks already while choosing. > (1/1) #1522960188 InvalidArgumentException > Language -1 does not exist on site root. > > one will never reach the preview. oh, und by the way: the ticket doesn't talk about preview, too. But about choosing, saving and breaking the BE.
  12. Raphael Graf commented on patch set 2 V +1 CR +1 10/17/18, 19:24

    I think the patch is correct. (fixes the backend issue for me)
  13. Alexander Grein commented on patch set 2 V +1 CR +1 10/18/18, 22:23

    The patch fixes the described problem – no more.
  14. Anja Leichsenring voted on patch set 2 V +2 CR +2 11/08/18, 20:21

  15. Anja Leichsenring merged patch set 3 11/08/18, 20:21