58615[BUGFIX] Detect recursions in PageContentErrorHandler
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Markus Klein +1
- Andreas Kienast +1
- Susi Moog +1
-
Verified V +2
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1113
-
Simon Praetorius uploaded patch set 1 10/11/18, 12:44
-
TYPO3com voted on patch set 1 V +1 10/11/18, 12:55 Completed build in 10m 33s on Thu, 11 Oct, 02:55 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29422
-
Markus Klein commented on patch set 1 10/11/18, 15:59
-
Simon Praetorius commented on patch set 1 10/11/18, 16:29
Yes, could be more readable. How about presetting $content to false before the if condition? -
Markus Klein commented on patch set 2 10/11/18, 19:44
Published edit on patch set 1. -
Markus Klein voted on patch set 2 CR +1 10/11/18, 19:45
-
TYPO3com voted on patch set 2 V +1 10/11/18, 19:56 Completed build in 11m 48s on Thu, 11 Oct, 09:56 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29429
-
Andreas Kienast voted on patch set 2 CR +1 10/13/18, 08:26
-
Susi Moog voted on patch set 2 CR +1 10/13/18, 10:56
-
Susi Moog voted on patch set 2 V +1 10/13/18, 11:02
-
Stefan Neufeind commented on patch set 2 10/13/18, 11:31
I tried pointing to a pageNotFound-document with an ID that does not exist - and wondered if that also triggers recursion. Something like requesting the non-existant page that points to itself as an error-document. That instead triggers a RuntimeException. Is it some handling that we might want to unify in a way? #1518472252 RuntimeException The requested page does not exist!<br /> <br /> Additionally, http://localhost/?id=998 was not found while trying to retrieve the error document. -
Benni Mack voted on patch set 2 V +2 CR +2 10/27/18, 20:23
-
Benni Mack merged patch set 3 10/27/18, 20:23
PageContentErrorHandler.php:74