Review main Merged

58616[BUGFIX] Correct tooltips for pages in the page tree

Tymoteusz Motylewski CR +2 V +2 Easy +18 −7 updated 10/13/18, 11:16

Commit message

Make tooltips for pages in the page tree correct (in case of shortcuts,
and mountpoints).

* add missing fields to selection in page tree Repository
required by BackendUtility->titleAttribForPages()
* add guard clauses for page 0 to avoid unnecessary processing
* fixes several notices

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Susi Moog +1
  • Verified V +2
    • Stefan Neufeind +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Tymoteusz Motylewski uploaded patch set 1 10/11/18, 14:33

  2. TYPO3com voted on patch set 1 V +1 10/11/18, 14:43 Completed build in 10m 31s on Thu, 11 Oct, 04:43 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29423

  3. Tymoteusz Motylewski updated the commit message in patch set 2 10/11/18, 14:44

  4. TYPO3com voted on patch set 2 V +1 10/11/18, 14:56 Completed build in 11m 01s on Thu, 11 Oct, 04:56 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29424

  5. Susi Moog voted on patch set 2 CR +1 10/13/18, 11:11

  6. Susi Moog voted on patch set 2 V +1 10/13/18, 11:12

  7. Stefan Neufeind voted on patch set 2 V +2 CR +2 10/13/18, 11:16

  8. Stefan Neufeind merged patch set 3 10/13/18, 11:16