Review main Merged

58621[TASK] Update typo3/testing-framework to 4.10.0

Nicole Hummel CR +2 V +2 Normal +14 −40 updated 10/29/18, 12:01

Commit message

Update from 4.9.0 to 4.10.0.
Notable change: The fluid RenderingContextFixture is
now provided by typo3/testing-framework, so core
namespace references can be adapted.

composer require --dev typo3/testing-framework ~4.10.0

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 914

  1. Nicole Hummel uploaded patch set 1 10/12/18, 10:43

  2. TYPO3com voted on patch set 1 V -1 10/12/18, 10:55 Completed build in 12m 10s on Fri, 12 Oct, 12:55 PM Test Summary: 2367 of 38161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29436

  3. Christian Kuhn uploaded patch set 2 10/29/18, 10:59

  4. Christian Kuhn commented on patch set 2 CR -1 10/29/18, 10:59

    wip, tag still missing.
  5. TYPO3com voted on patch set 2 V -1 10/29/18, 11:16 Completed build in 16m 16s on Mon, 29 Oct, 12:16 PM Test Summary: 894 of 38530 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29815

  6. Christian Kuhn uploaded patch set 3 10/29/18, 11:28

  7. TYPO3com voted on patch set 3 V -1 10/29/18, 11:39 Completed build in 11m 15s on Mon, 29 Oct, 12:39 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29819

  8. Christian Kuhn uploaded patch set 4 10/29/18, 11:41

  9. Christian Kuhn uploaded patch set 5 10/29/18, 11:42

  10. TYPO3com voted on patch set 4 V -1 10/29/18, 11:53 Completed build in 12m 33s on Mon, 29 Oct, 12:53 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29820

  11. TYPO3com voted on patch set 5 V +1 10/29/18, 11:55 Completed build in 12m 52s on Mon, 29 Oct, 12:55 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29821

  12. Christian Kuhn voted on patch set 5 V +1 CR +1 10/29/18, 11:59

  13. Anja Leichsenring voted on patch set 5 V +2 CR +2 10/29/18, 12:01

  14. Anja Leichsenring merged patch set 6 10/29/18, 12:01