Review main Merged

58624[TASK] Move FieldControl/InsertClipboard handling to module

Andreas Kienast CR +2 V +2 Normal +94 −21 updated 10/29/18, 22:11

Commit message

The FieldControl `InsertClipboard` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 811

  1. Andreas Kienast uploaded patch set 1 10/13/18, 10:54

  2. Andreas Kienast commented on patch set 1 V -1 CR -1 10/13/18, 10:54

  3. TYPO3com voted on patch set 1 V -1 10/13/18, 10:54 Completed build in 15s on Sat, 13 Oct, 12:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29440

  4. Andreas Kienast uploaded patch set 2 10/29/18, 20:52

  5. TYPO3com voted on patch set 2 V +1 10/29/18, 21:08 Completed build in 14m 44s on Mon, 29 Oct, 10:08 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29843

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 10/29/18, 21:15

  7. Christian Kuhn uploaded patch set 3 10/29/18, 21:43

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 10/29/18, 21:44

  9. TYPO3com voted on patch set 3 V +1 10/29/18, 21:57 Completed build in 13m 43s on Mon, 29 Oct, 10:57 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29851

  10. Wouter Wolters voted on patch set 3 V +2 CR +2 10/29/18, 22:11

  11. Wouter Wolters merged patch set 4 10/29/18, 22:11