58631[BUGFIX] Decouple GeneralUtility::rmdir from Environment::isWindows()
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Christian Kuhn +1
- Susi Moog +1
-
Verified V +2
- Benni Mack +2
- Christian Kuhn +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 78
-
Nicole Hummel uploaded patch set 1 10/14/18, 19:13
-
TYPO3com voted on patch set 1 V +1 10/14/18, 19:23 Completed build in 10m 29s on Sun, 14 Oct, 09:23 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29450
-
Stefan Neufeind commented on patch set 1 10/15/18, 09:36
I'm unsure if we should "fix" it in rmdir here - maybe instead with a fallback centrally in Environment::isWindows() if $os is not initialized yet. Nicole and I briefly discussed it, and she's prefer the "simple" approach suggested here. Somebody please make an architectual decision imho. -
Susi Moog voted on patch set 1 CR +1 10/28/18, 10:08
-
Susi Moog voted on patch set 1 V +1 10/28/18, 10:26
-
Christian Kuhn voted on patch set 1 V +1 CR +1 10/28/18, 10:43
-
Benni Mack voted on patch set 1 V +2 CR +2 10/28/18, 10:43
-
Benni Mack merged patch set 2 10/28/18, 10:43