Review main Abandoned

58636[BUGFIX] Pass Expire header as string in getHttpHeadersForTemporaryContent

Andreas Häfner CR 0 V 0 Easy +1 −1 updated 10/15/18, 12:47

Commit message

\TYPO3\CMS\Core\Http\Message::withHeader expects string values for all
headers, Expire-header is casted to string in this method.
This prevents Exeption thrown \TYPO3\CMS\Core\Http\Message::withHeader.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Andreas Häfner uploaded patch set 1 10/15/18, 12:14

  2. TYPO3com voted on patch set 1 V +1 10/15/18, 12:27 Completed build in 12m 14s on Mon, 15 Oct, 02:27 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29453

  3. Wouter Wolters commented on patch set 1 10/15/18, 12:47

    Hi, thanks for the patch. However there is already a review pending at https://review.typo3.org/#/c/58562/ Please continue there. I will abandon this review here.
  4. Wouter Wolters abandoned the change 10/15/18, 12:47