Review main Merged

58641[BUGFIX] Fix argument ordering of RecordHistoryStore

Georg Ringer CR +2 V +2 Easy +3 −2 updated 10/18/18, 06:14

Commit message

The DataHandler must use the correct ordering of arguments of
RecordHistoryStore. Furthermore the sorting of the arguments in the
doc block is fixed.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2
    • Stefan Neufeind +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Georg Ringer uploaded patch set 1 10/15/18, 19:48

  2. TYPO3com voted on patch set 1 V +1 10/15/18, 19:59 Completed build in 10m 39s on Mon, 15 Oct, 09:59 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29461

  3. Tymoteusz Motylewski commented on patch set 1 10/16/18, 07:51

    RecordHistoryStore.php:74

    can we also sort these assignments to match order of parameters, it will be easier to read.
  4. Georg Ringer uploaded patch set 2 10/17/18, 08:02

  5. TYPO3com voted on patch set 2 V +1 10/17/18, 08:13 Completed build in 10m 37s on Wed, 17 Oct, 10:13 AM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29466

  6. Andreas Kienast voted on patch set 2 CR +1 10/17/18, 09:26

  7. Stefan Neufeind voted on patch set 2 CR +1 10/17/18, 09:37

  8. Markus Klein voted on patch set 2 V +1 CR +1 10/17/18, 09:47

  9. Stefan Neufeind voted on patch set 2 V +2 CR +2 10/17/18, 10:07

  10. Stefan Neufeind merged patch set 3 10/17/18, 10:07

  11. Oliver Hader voted on patch set 3 CR +1 10/18/18, 06:14