Review main Merged

58647[TASK] Raise version of typo3/phar-stream-wrapper to 3.0.1

Oliver Hader CR +2 V +2 Easy +15 −10 updated 10/19/18, 06:39

Commit message

composer require typo3/phar-stream-wrapper:^3.0.1

Review

  • Code review CR +2
    • Oliver Hader +2
    • Georg Ringer +1
    • Mathias Brodala +1
  • Verified V +2
    • Oliver Hader +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1113

  1. Oliver Hader uploaded patch set 1 10/18/18, 10:16

  2. Georg Ringer commented on patch set 1 10/18/18, 10:19

    normally we write the composer update command here as well
  3. Mathias Brodala commented on patch set 1 CR -1 10/18/18, 10:24

    composer.json:46

    This needs to be copied to the root composer.json too.
  4. Oliver Hader commented on patch set 1 10/18/18, 10:25

    @Georg: Do you have an example?
  5. Oliver Hader commented on patch set 1 10/18/18, 10:26

    composer.json:46 Reply

    Is there another root composer.json?!
  6. TYPO3com voted on patch set 1 V +1 10/18/18, 10:27 Completed build in 10m 24s on Thu, 18 Oct, 12:27 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29472

  7. Oliver Hader updated the commit message in patch set 2 10/18/18, 10:28

  8. TYPO3com voted on patch set 2 V +1 10/18/18, 10:40 Completed build in 11m 40s on Thu, 18 Oct, 12:40 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29473

  9. Mathias Brodala commented on patch set 1 10/18/18, 10:48

    composer.json:46 Reply

    No, sorry I missed that you already updated what I meant.
  10. Mathias Brodala voted on patch set 2 CR +1 10/18/18, 10:48

  11. Georg Ringer voted on patch set 2 V +1 CR +1 10/18/18, 16:24

  12. Oliver Hader voted on patch set 2 V +2 CR +2 10/19/18, 06:39

  13. Oliver Hader merged patch set 3 10/19/18, 06:39