Review main Merged

58648[TASK] Move FieldControl/AddRecord handling to module

Andreas Kienast CR +2 V +2 Normal +61 −4 updated 10/29/18, 21:42

Commit message

The FieldControl `AddRecord` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1116

  1. Andreas Kienast uploaded patch set 1 10/18/18, 13:20

  2. Andreas Kienast uploaded patch set 2 10/18/18, 13:23

  3. TYPO3com voted on patch set 1 V +1 10/18/18, 13:36 Completed build in 16m 12s on Thu, 18 Oct, 03:36 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29475

  4. TYPO3com voted on patch set 2 V +1 10/18/18, 13:43 Completed build in 17m 05s on Thu, 18 Oct, 03:43 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29476

  5. Andreas Kienast commented on patch set 2 CR -1 10/18/18, 14:15

  6. Andreas Kienast uploaded patch set 3 10/29/18, 20:42

  7. Andreas Kienast commented on patch set 4 10/29/18, 20:48

    Published edit on patch set 3.
  8. Christian Kuhn voted on patch set 4 V +1 CR +1 10/29/18, 20:49

  9. Andreas Kienast uploaded patch set 5 10/29/18, 20:53

  10. TYPO3com voted on patch set 3 V +1 10/29/18, 20:54 Completed build in 12m 30s on Mon, 29 Oct, 09:54 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29840

  11. Christian Kuhn voted on patch set 5 V +1 CR +1 10/29/18, 21:00

  12. TYPO3com voted on patch set 4 V +1 10/29/18, 21:02 Completed build in 13m 10s on Mon, 29 Oct, 10:02 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29841

  13. TYPO3com voted on patch set 5 V +1 10/29/18, 21:13 Completed build in 19m 53s on Mon, 29 Oct, 10:13 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29844

  14. Anja Leichsenring voted on patch set 5 V +1 CR +1 10/29/18, 21:41

  15. Anja Leichsenring voted on patch set 5 V +2 CR +2 10/29/18, 21:42

  16. Anja Leichsenring merged patch set 6 10/29/18, 21:42