Review main Merged

58649[TASK] Move FieldControl/ListModule handling to module

Andreas Kienast CR +2 V +2 Normal +60 −4 updated 10/29/18, 22:30

Commit message

The FieldControl `ListModule` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • Christian Kuhn +1

Issues 1

Files 3

Review log 1115

  1. Andreas Kienast uploaded patch set 1 10/18/18, 13:27

  2. TYPO3com voted on patch set 1 V +1 10/18/18, 13:47 Completed build in 16m 38s on Thu, 18 Oct, 03:47 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29477

  3. Andreas Kienast commented on patch set 1 CR -1 10/18/18, 14:15

  4. Andreas Kienast uploaded patch set 2 10/29/18, 20:57

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/29/18, 21:17

  6. TYPO3com voted on patch set 2 V +1 10/29/18, 21:23 Completed build in 20m 19s on Mon, 29 Oct, 10:23 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29846

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/29/18, 22:03

  8. Wouter Wolters uploaded patch set 3 10/29/18, 22:13

  9. Christian Kuhn rebased onto patch set 4 10/29/18, 22:13

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 10/29/18, 22:14

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 10/29/18, 22:15

  12. Wouter Wolters voted on patch set 4 V +2 CR +2 10/29/18, 22:26

  13. Wouter Wolters merged patch set 5 10/29/18, 22:26

  14. TYPO3com voted on patch set 3 V +1 10/29/18, 22:26 Completed build in 13m 16s on Mon, 29 Oct, 11:26 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29854

  15. TYPO3com voted on patch set 4 V +1 10/29/18, 22:30 Completed build in 16m 26s on Mon, 29 Oct, 11:30 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29855