Review main Merged

58650[TASK] Move FieldControl/TableWizard handling to module

Andreas Kienast CR +2 V +2 Normal +60 −4 updated 10/29/18, 21:48

Commit message

The FieldControl `TableWizard` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 68

  1. Andreas Kienast uploaded patch set 1 10/18/18, 13:32

  2. TYPO3com voted on patch set 1 V +1 10/18/18, 13:49 Completed build in 13m 14s on Thu, 18 Oct, 03:49 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29478

  3. Andreas Kienast commented on patch set 1 CR -1 10/18/18, 14:15

  4. Andreas Kienast uploaded patch set 2 10/29/18, 21:05

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/29/18, 21:09

  6. TYPO3com voted on patch set 2 V +1 10/29/18, 21:26 Completed build in 14m 17s on Mon, 29 Oct, 10:26 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29847

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/29/18, 21:48

  8. Anja Leichsenring merged patch set 3 10/29/18, 21:48