Review main Merged

58651[TASK] Move FieldControl/ResetSelection handling to module

Andreas Kienast CR +2 V +2 Normal +69 −8 updated 10/29/18, 21:39

Commit message

The FieldControl `ResetSelection` now uses a dedicated module for its
handling and no longer uses inline `onclick` handlers nor inline
FormEngine calls.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1422

  1. Andreas Kienast uploaded patch set 1 10/18/18, 14:07

  2. TYPO3com voted on patch set 1 V -1 10/18/18, 14:07 Completed build in 08s on Thu, 18 Oct, 04:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29479

  3. Andreas Kienast uploaded patch set 2 10/18/18, 14:08

  4. Andreas Kienast uploaded patch set 3 10/18/18, 14:15

  5. Andreas Kienast commented on patch set 3 CR -1 10/18/18, 14:15

  6. TYPO3com voted on patch set 2 V +1 10/18/18, 14:19 Completed build in 10m 56s on Thu, 18 Oct, 04:19 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29480

  7. TYPO3com voted on patch set 3 V +1 10/18/18, 14:29 Completed build in 13m 56s on Thu, 18 Oct, 04:29 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29482

  8. Stefan Neufeind commented on patch set 3 V +1 10/23/18, 21:52

    tested with #58623
  9. Andreas Kienast uploaded patch set 4 10/29/18, 20:22

  10. Andreas Kienast uploaded patch set 5 10/29/18, 20:25

  11. Andreas Kienast uploaded patch set 6 10/29/18, 20:32

  12. TYPO3com voted on patch set 4 V +1 10/29/18, 20:35 Completed build in 12m 22s on Mon, 29 Oct, 09:35 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29837

  13. TYPO3com voted on patch set 5 V +1 10/29/18, 20:38 Completed build in 12m 55s on Mon, 29 Oct, 09:38 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29838

  14. Christian Kuhn voted on patch set 6 V +1 CR +1 10/29/18, 20:42

  15. TYPO3com voted on patch set 6 V +1 10/29/18, 20:44 Completed build in 11m 56s on Mon, 29 Oct, 09:44 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29839

  16. Andreas Kienast commented on patch set 7 10/29/18, 20:49

    Published edit on patch set 6.
  17. Andreas Kienast uploaded patch set 8 10/29/18, 20:55

  18. TYPO3com voted on patch set 7 V +1 10/29/18, 21:05 Completed build in 16m 15s on Mon, 29 Oct, 10:05 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29842

  19. Christian Kuhn voted on patch set 8 V +1 CR +1 10/29/18, 21:07

  20. TYPO3com voted on patch set 8 V +1 10/29/18, 21:17 Completed build in 14m 08s on Mon, 29 Oct, 10:17 PM Test Summary: 38170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29845

  21. Anja Leichsenring voted on patch set 8 V +2 CR +2 10/29/18, 21:39

  22. Anja Leichsenring merged patch set 9 10/29/18, 21:39