Review main Merged

58661[BUGFIX] Avoid overwriting page context in TSFE->cObj by f:cObject

Thorben Nissen CR +2 V +2 Easy +8 −3 updated 03/02/19, 15:01

Commit message

Change `CObjectViewHelper::getContentObjectRenderer` to return a new
instance of `ContentObjectRenderer` instead of returning a reference to
`TSFE->cObj`.

Change unit test and add prepared instance of `ContentObjectRenderer`
to `GeneralUtility` via `addInstance` method.

Review

  • Code review CR +2
    • Markus Klein +2
    • Helmut Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2838

Show 813 earlier messages
  1. Thorben Nissen uploaded patch set 1 10/19/18, 09:09

  2. TYPO3com voted on patch set 1 V -1 10/19/18, 09:21 Completed build in 12m 36s on Fri, 19 Oct, 11:21 AM Test Summary: 3 of 38161 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29488

  3. Thorben Nissen uploaded patch set 2 10/19/18, 13:13

  4. TYPO3com voted on patch set 2 V +1 10/19/18, 13:24 Completed build in 11m 04s on Fri, 19 Oct, 03:24 PM Test Summary: 37801 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29491

  5. Benni Mack commented on patch set 2 10/26/18, 14:14

    Hey Thorben, how does that patch solve the issue mentioned?
  6. Benni Mack uploaded patch set 3 10/29/18, 10:12

  7. TYPO3com voted on patch set 3 V -1 10/29/18, 10:36 Completed build in 16m 59s on Mon, 29 Oct, 11:36 AM Test Summary: 1839 of 38530 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29810

  8. David Aichi commented on patch set 3 V +1 11/23/18, 08:12

    fixed the issue
  9. Josef Glatz commented on patch set 3 V +1 11/27/18, 13:18

    +1 This fixes the issue! This is a really important fix, as this is heavily used by integrators
  10. Georg Ringer rebased onto patch set 4 12/04/18, 12:33

  11. TYPO3com voted on patch set 4 V -1 12/04/18, 12:45 Completed build in 12m 06s on Tue, 4 Dec, 01:45 PM Test Summary: 3579 of 48960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30427

  12. Georg Ringer uploaded patch set 5 12/04/18, 12:56

  13. TYPO3com voted on patch set 5 V +1 12/04/18, 13:09 Completed build in 12m 37s on Tue, 4 Dec, 02:09 PM Test Summary: 48548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30429

  1. Thorben Nissen voted on patch set 5 CR +1 12/04/18, 15:14

  2. Josef Glatz voted on patch set 5 V +1 CR +1 12/06/18, 11:45

  3. Helmut Hummel commented on patch set 5 12/06/18, 15:52

    The change in general looks fine. However, if the analysis of Claus is correct: https://forge.typo3.org/issues/76489#note-1, then this change will not fix the original issue, because still $GLOBALS['TSFE'] will be passed to ContentObjectRenderer and can potentially be mutated. If the original issue is that $GLOBALS['TSFE']->cObj is mutated, then this change should be fine and a nice cleanup
  4. Thorben Nissen commented on patch set 5 12/06/18, 16:21

    @Helmut: Isn't the TSFE re-used in several places throughout the core? So, this should not be a problem. The currently happening manipulation of TSFE->cObj is the problem.
  5. Josef Glatz updated the commit message in patch set 6 12/06/18, 16:47

  6. TYPO3com voted on patch set 6 V +1 12/06/18, 16:58 Completed build in 11m 15s on Thu, 6 Dec, 05:58 PM Test Summary: 48564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30478

  7. Josef Glatz updated the commit message in patch set 7 12/06/18, 17:35

  8. Josef Glatz updated the commit message in patch set 8 12/06/18, 17:37

  9. Josef Glatz voted on patch set 8 V +1 CR +1 12/06/18, 17:39

  10. Markus Klein commented on patch set 8 12/06/18, 17:40

  11. TYPO3com voted on patch set 7 V +1 12/06/18, 17:48 Completed build in 13m 00s on Thu, 6 Dec, 06:48 PM Test Summary: 48564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30479

  12. TYPO3com voted on patch set 8 V +1 12/06/18, 17:50 Completed build in 13m 07s on Thu, 6 Dec, 06:50 PM Test Summary: 48564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30480

  13. Helmut Hummel updated the commit message in patch set 9 12/06/18, 18:18

  14. Helmut Hummel commented on patch set 9 V +1 CR +1 12/06/18, 18:21

    I'm not sure whether this change really fixes #76489, as this bug report dates back to TYPO3 7 and this change here does not change anything related to the behaviour back then. In fact it restores the behaviour change introduced here: https://github.com/TYPO3/TYPO3.CMS/commit/11c873f00f74d3210f9c31a1d00d2a136cd5c795 And definitely fixes the bug mentions in #86979 Therefore I removed Resolves #76489 as this important regression fix can go in
  15. Josef Glatz voted on patch set 9 V +1 CR +1 12/06/18, 18:21

  16. TYPO3com voted on patch set 9 V +1 12/06/18, 18:29 Completed build in 11m 09s on Thu, 6 Dec, 07:29 PM Test Summary: 48564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30481

  17. Markus Klein commented on patch set 9 12/06/18, 18:37

    CObjectViewHelper.php:141

    Si the removal of those things really related to the reported bug in forge??
  18. Markus Klein commented on patch set 9 CR -1 12/07/18, 20:07

    As briefly discussed with Helmut, I suggest to not touch the BE related code stuff with this regression fix. Lets do that maybe separately.
  19. Josef Glatz uploaded patch set 10 12/07/18, 20:56

  20. TYPO3com voted on patch set 10 V +1 12/07/18, 21:19 Completed build in 21m 09s on Fri, 7 Dec, 10:19 PM Test Summary: 48716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30529

  21. Helmut Hummel voted on patch set 10 V +1 CR +1 12/07/18, 22:06

  22. Markus Klein voted on patch set 10 V +2 CR +2 12/07/18, 22:12

  23. Markus Klein merged patch set 11 12/07/18, 22:12

  24. Markus Klein commented on patch set 11 12/17/18, 19:14

    CObjectViewHelper.php:161

    unfortunately class is not imported: https://forge.typo3.org/issues/87186
  25. Riccardo De Contardi commented on patch set 11 03/02/19, 15:01

    Hasn't the patch from https://forge.typo3.org/issues/87186 been merged, too? Is there still work to do here?