Review main Merged

58671[BUGFIX] Remove `fbclid` argument from chash calculation

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 10/23/18, 17:59

Commit message

Facebook adds the `fbclid` argument to outbound URLs which triggers a
recalculcation of the cache hash. The argument is now added to the
blacklist for chash parameters.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Josef Glatz +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Tim Schreiner +1
    • Jörg Bösche +1
  • Verified V +2
    • Anja Leichsenring +2
    • Stefan Neufeind +1
    • Josef Glatz +1
    • Georg Ringer +1
    • Tim Schreiner +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Andreas Kienast uploaded patch set 1 10/23/18, 06:17

  2. TYPO3com voted on patch set 1 V +1 10/23/18, 06:29 Completed build in 11m 29s on Tue, 23 Oct, 08:29 AM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29519

  3. Georg Ringer voted on patch set 1 V +1 CR +1 10/23/18, 07:57

  4. Josef Glatz voted on patch set 1 V +1 CR +1 10/23/18, 07:58

  5. Jörg Bösche voted on patch set 1 V +1 CR +1 10/23/18, 09:56

  6. Oliver Klee voted on patch set 1 CR +1 10/23/18, 12:35

  7. Stefan Neufeind voted on patch set 1 V +1 CR +1 10/23/18, 16:31

  8. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/23/18, 17:51

  9. Anja Leichsenring merged patch set 2 10/23/18, 17:51

  10. Tim Schreiner voted on patch set 2 V +1 CR +1 10/23/18, 17:59