Review TYPO3_8-7 Merged

58672[BUGFIX] Remove `fbclid` argument from chash calculation

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 10/23/18, 17:59

Commit message

Facebook adds the `fbclid` argument to outbound URLs which triggers a
recalculcation of the cache hash. The argument is now added to the
blacklist for chash parameters.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Tim Schreiner +1
    • Jörg Bösche +1
  • Verified V +2
    • Anja Leichsenring +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Tim Schreiner +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Andreas Kienast uploaded patch set 1 10/23/18, 06:20

  2. Andreas Kienast updated the commit message in patch set 2 10/23/18, 06:21

  3. TYPO3com voted on patch set 2 V +1 10/23/18, 06:32 Completed build in 09m 21s on Tue, 23 Oct, 08:32 AM Test Summary: 59600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3077

  4. TYPO3com voted on patch set 1 V +1 10/23/18, 06:32 Completed build in 11m 32s on Tue, 23 Oct, 08:32 AM Test Summary: 59600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3076

  5. Georg Ringer voted on patch set 2 V +1 CR +1 10/23/18, 07:57

  6. Josef Glatz voted on patch set 2 V +1 CR +1 10/23/18, 07:58

  7. Jörg Bösche voted on patch set 2 V +1 CR +1 10/23/18, 09:56

  8. Oliver Klee voted on patch set 2 CR +1 10/23/18, 12:36

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/23/18, 17:52

  10. Anja Leichsenring merged patch set 3 10/23/18, 17:52

  11. Tim Schreiner voted on patch set 3 V +1 CR +1 10/23/18, 17:59