Review main Abandoned

58673[TASK] Make crop settings accessible for 3rd-party developers

Xavier Perseguers CR 0 V 0 Easy +21 −0 updated 10/24/18, 06:51

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1114

  1. Xavier Perseguers uploaded patch set 1 10/23/18, 08:43

  2. TYPO3com voted on patch set 1 V -1 10/23/18, 08:43 Completed build in 09s on Tue, 23 Oct, 10:43 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29520

  3. Andreas Kienast uploaded patch set 2 10/23/18, 08:46

  4. TYPO3com voted on patch set 2 V +1 10/23/18, 08:57 Completed build in 11m 03s on Tue, 23 Oct, 10:57 AM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29521

  5. Jörg Bösche voted on patch set 2 CR +1 10/23/18, 09:54

  6. Oliver Klee commented on patch set 2 CR -1 10/23/18, 12:37

    FileReference.php:37

    For the getter to now throw a warning, this needs to have an empty string as a default value. On it.
  7. Oliver Klee commented on patch set 3 10/23/18, 12:37

    Published edit on patch set 2.
  8. Oliver Klee commented on patch set 3 10/23/18, 12:39

    And we should cover this with unit tests (which would have caught the type problem).
  9. TYPO3com voted on patch set 3 V +1 10/23/18, 12:48 Completed build in 10m 32s on Tue, 23 Oct, 02:48 PM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29527

  10. Stefan Neufeind voted on patch set 3 CR +1 10/23/18, 16:32

  11. Frans Saris commented on patch set 3 CR -1 10/23/18, 17:22

    What about all the other properties? title, etc Why is crop any different? You can access the value by is getOriginalResource()
  12. Xavier Perseguers commented on patch set 3 10/24/18, 06:48

    @Frans did you actually tried what you suggest? The crop is not related to the original file but to the file reference (see in DB). When you reference an image, you may crop it, but you specify the crop for the corresponding reference, meaning you may reference multiple times the same file with various crop settings...
  13. Xavier Perseguers commented on patch set 3 10/24/18, 06:51

    oops, sorry, indeed the crop attribute is available, not with getOrignalResource() but with $crop = $file->getReferenceProperty('crop'); your telling about title made me think about it again and seek for something I missed in my former version of the code. Thanks for pointing out.
  14. Xavier Perseguers abandoned the change 10/24/18, 06:51

    $crop = $file->getReferenceProperty('crop');