58674[FEATURE] Add a telephone (tel:) link handler
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Jan Helke +1
- Jörg Bösche +1
- Mona Muzaffar +1
-
Verified V +2
- Anja Leichsenring +2
- Jan Helke +1
- Mona Muzaffar +1
- TYPO3com +1 CI
Issues 1
Files 12
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+3 −0
- typo3/sysext/core/Classes/LinkHandling/LinkService.php+4 −0
- typo3/sysext/core/Classes/LinkHandling/TelephoneLinkHandler.php1new+48 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-86629-ImplementLinkHandlerForTelephoneNumbers.rst1new+18 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/TelephoneLinkHandlerTest.php2new+102 −0
- typo3/sysext/frontend/Classes/Typolink/TelephoneLinkBuilder.phpnew+30 −0
- typo3/sysext/recordlist/Classes/LinkHandler/TelephoneLinkHandler.php1new+107 −0
- typo3/sysext/recordlist/Resources/Private/Language/locallang_browse_links.xlf+6 −0
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/Telephone.htmlnew+19 −0
- typo3/sysext/recordlist/Resources/Public/JavaScript/TelephoneLinkHandler.js1new+45 −0
- typo3/sysext/recordlist/ext_localconf.php+8 −1
Review log 1822
-
Rune Piper uploaded patch set 1 10/23/18, 13:44
-
TYPO3com voted on patch set 1 V +1 10/23/18, 13:55 Completed build in 10m 46s on Tue, 23 Oct, 03:55 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29530
-
Andreas Kienast commented on patch set 1 10/23/18, 16:33
-
Rune Piper uploaded patch set 2 10/24/18, 06:00
-
TYPO3com voted on patch set 2 V +1 10/24/18, 06:12 Completed build in 12m 43s on Wed, 24 Oct, 08:12 AM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29532
-
Andreas Kienast commented on patch set 2 CR -1 10/24/18, 06:23
Feature-86629-ImplementLinkHandlerForTelephoneNumbers.rst:12UnresolvedPlease describe what this feature does and how it can be used. Mention "tel:", "telephone" for TCEMAIN.linkHandler and that stuff ;)TelephoneLinkHandlerTest.php:1UnresolvedPlease add declare(strict_types = 1); for new classes and use proper type declarationsTelephoneLinkHandlerTest.php:40UnresolvedCan we have additional tests that a) test something that doesn't evaluate to a valid phone number b) weird characters (like $%")TelephoneLinkHandler.php:1UnresolvedPlease add declare(strict_types = 1); for new classes and use proper type declarationsTelephoneLinkHandler.js:37UnresolvedWhat do you want to achieve here? When we're having tel:tel:tel: links then something is broken in first place. -
Wolfgang Klinger uploaded patch set 3 11/23/18, 16:24
-
Wolfgang Klinger commented on patch set 3 V +1 CR +1 11/23/18, 16:26
I fixed all the problems, updated the feature description and added missing code in the LinkService and LegacyLinkNotationConverter class. -
TYPO3com voted on patch set 3 V +1 11/23/18, 16:35 Completed build in 10m 36s on Fri, 23 Nov, 05:35 PM Test Summary: 48516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30262
-
Jörg Bösche voted on patch set 3 CR +1 12/06/18, 12:31
-
Jan Helke commented on patch set 3 V -1 12/07/18, 16:21
Can't verify that the patch is working. I created a new content, selected the new link option telephone, entered a (valid) number and saved. In the frontend I got just the entered string, but no link nor number. -
Andreas Kienast commented on patch set 3 V -1 CR -1 12/07/18, 16:49
Can confirm the issue Jan reported. A LinkBuilder is missing, that's why the phone numbers don't get restored. -
Andreas Kienast uploaded patch set 4 12/07/18, 16:51
-
Jan Helke voted on patch set 4 V +1 CR +1 12/07/18, 16:53
-
TYPO3com voted on patch set 4 V +1 12/07/18, 17:02 Completed build in 10m 47s on Fri, 7 Dec, 06:02 PM Test Summary: 48608 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30512
-
Anja Leichsenring commented on patch set 4 V -1 12/07/18, 17:04
blocked until branching to v10. -
Jörg Bösche voted on patch set 4 CR +1 01/10/19, 21:35
-
Anja Leichsenring voted on patch set 4 V 0 01/11/19, 06:44
-
Mona Muzaffar voted on patch set 4 V +1 01/11/19, 09:45
-
Mona Muzaffar voted on patch set 4 CR +1 01/11/19, 09:50
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 01/11/19, 09:53
-
Anja Leichsenring merged patch set 5 01/11/19, 09:53
TelephoneLinkHandler.php:36Unresolved