Review main Merged

58674[FEATURE] Add a telephone (tel:) link handler

Rune Piper CR +2 V +2 Hard +392 −1 updated 01/11/19, 09:53

Commit message

The new link handler allows you to set links
in a new tab in the link browser to
phone numbers using the tel: protocol.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Jan Helke +1
    • Jörg Bösche +1
    • Mona Muzaffar +1
  • Verified V +2
    • Anja Leichsenring +2
    • Jan Helke +1
    • Mona Muzaffar +1
    • TYPO3com +1 CI

Issues 1

Files 12

Review log 1822

  1. Rune Piper uploaded patch set 1 10/23/18, 13:44

  2. TYPO3com voted on patch set 1 V +1 10/23/18, 13:55 Completed build in 10m 46s on Tue, 23 Oct, 03:55 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29530

  3. Andreas Kienast commented on patch set 1 10/23/18, 16:33

    TelephoneLinkHandler.php:36 Unresolved

    I think doing this or alike is a safer approach: $telephoneNumber = preg_replace('/(?:[^\d\+]+)/', '', $telephoneNumber);
  4. Rune Piper uploaded patch set 2 10/24/18, 06:00

  5. TYPO3com voted on patch set 2 V +1 10/24/18, 06:12 Completed build in 12m 43s on Wed, 24 Oct, 08:12 AM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29532

  6. Andreas Kienast commented on patch set 2 CR -1 10/24/18, 06:23

    Feature-86629-ImplementLinkHandlerForTelephoneNumbers.rst:12 Unresolved

    Please describe what this feature does and how it can be used. Mention "tel:", "telephone" for TCEMAIN.linkHandler and that stuff ;)

    TelephoneLinkHandlerTest.php:1 Unresolved

    Please add declare(strict_types = 1); for new classes and use proper type declarations

    TelephoneLinkHandlerTest.php:40 Unresolved

    Can we have additional tests that a) test something that doesn't evaluate to a valid phone number b) weird characters (like $%")

    TelephoneLinkHandler.php:1 Unresolved

    Please add declare(strict_types = 1); for new classes and use proper type declarations

    TelephoneLinkHandler.js:37 Unresolved

    What do you want to achieve here? When we're having tel:tel:tel: links then something is broken in first place.
  7. Wolfgang Klinger uploaded patch set 3 11/23/18, 16:24

  8. Wolfgang Klinger commented on patch set 3 V +1 CR +1 11/23/18, 16:26

    I fixed all the problems, updated the feature description and added missing code in the LinkService and LegacyLinkNotationConverter class.
  9. TYPO3com voted on patch set 3 V +1 11/23/18, 16:35 Completed build in 10m 36s on Fri, 23 Nov, 05:35 PM Test Summary: 48516 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30262

  10. Jörg Bösche voted on patch set 3 CR +1 12/06/18, 12:31

  11. Jan Helke commented on patch set 3 V -1 12/07/18, 16:21

    Can't verify that the patch is working. I created a new content, selected the new link option telephone, entered a (valid) number and saved. In the frontend I got just the entered string, but no link nor number.
  12. Andreas Kienast commented on patch set 3 V -1 CR -1 12/07/18, 16:49

    Can confirm the issue Jan reported. A LinkBuilder is missing, that's why the phone numbers don't get restored.
  13. Andreas Kienast uploaded patch set 4 12/07/18, 16:51

  14. Jan Helke voted on patch set 4 V +1 CR +1 12/07/18, 16:53

  15. TYPO3com voted on patch set 4 V +1 12/07/18, 17:02 Completed build in 10m 47s on Fri, 7 Dec, 06:02 PM Test Summary: 48608 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30512

  16. Anja Leichsenring commented on patch set 4 V -1 12/07/18, 17:04

    blocked until branching to v10.
  17. Jörg Bösche voted on patch set 4 CR +1 01/10/19, 21:35

  18. Anja Leichsenring voted on patch set 4 V 0 01/11/19, 06:44

  19. Mona Muzaffar voted on patch set 4 V +1 01/11/19, 09:45

  20. Mona Muzaffar voted on patch set 4 CR +1 01/11/19, 09:50

  21. Anja Leichsenring voted on patch set 4 V +2 CR +2 01/11/19, 09:53

  22. Anja Leichsenring merged patch set 5 01/11/19, 09:53