Review TYPO3_7-6 Merged

58676[BUGFIX] Remove `fbclid` argument from chash calculation

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 11/06/18, 09:58

Commit message

Facebook adds the `fbclid` argument to outbound URLs which triggers a
recalculcation of the cache hash. The argument is now added to the
blacklist for chash parameters.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Tim Schreiner +1
  • Verified V +2
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 10/23/18, 17:56

  2. Tim Schreiner voted on patch set 1 CR +1 10/23/18, 18:00

  3. TYPO3com voted on patch set 1 V +1 10/23/18, 18:06 Completed build in 07m 27s on Tue, 23 Oct, 08:06 PM Test Summary: 49502 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1570

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 10/23/18, 18:07

  5. Anja Leichsenring merged patch set 2 10/23/18, 18:07

  6. Armin Vieweg commented on patch set 2 11/06/18, 09:47

    Why do you add "fbclid" by default, but skip e.g. "gclid"? RealURL also added "fbclid" recently in their code... but they had "gclid" already configured.
  7. Andreas Kienast commented on patch set 2 11/06/18, 09:58

    > Why do you add "fbclid" by default, but skip e.g. "gclid"? RealURL > also added "fbclid" recently in their code... but they had "gclid" > already configured. 1.) The bug report was about "fbclid" 2.) I don't know every parameter facebook adds to outbound URLs 3.) I don't care about RealURL :)