Review main Merged

58682[BUGFIX] Assure that $_POST is never set to null

Daniel Goerz CR +2 V +2 Easy +5 −3 updated 10/24/18, 13:04

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Sattler +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Sattler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Daniel Goerz uploaded patch set 1 10/24/18, 08:07

  2. Daniel Goerz updated the commit message in patch set 2 10/24/18, 08:08

  3. Andreas Kienast voted on patch set 2 CR +1 10/24/18, 08:16

  4. Benni Mack commented on patch set 2 10/24/18, 08:17

    RequestHandler.php:129

    should we add $request->getParsedBody() ?? [] in the if() condition?
  5. Daniel Goerz commented on patch set 2 CR -1 10/24/18, 08:19

    RequestHandler.php:129 Reply

    yes, makes sense. The ServerRequestInterface however states, that ->getParsedBody() may return an object. I have no Idea what happens in that case and how to force that for testing.
  6. TYPO3com voted on patch set 1 V +1 10/24/18, 08:20 Completed build in 13m 14s on Wed, 24 Oct, 10:20 AM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29534

  7. TYPO3com voted on patch set 2 V +1 10/24/18, 08:21 Completed build in 13m 19s on Wed, 24 Oct, 10:21 AM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29535

  8. Daniel Goerz uploaded patch set 3 10/24/18, 08:38

  9. TYPO3com voted on patch set 3 V +1 10/24/18, 08:49 Completed build in 11m 05s on Wed, 24 Oct, 10:49 AM Test Summary: 37807 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29537

  10. Daniel Sattler voted on patch set 3 V +1 CR +1 10/24/18, 11:44

  11. Benni Mack voted on patch set 3 V +2 CR +2 10/24/18, 13:04

  12. Benni Mack merged patch set 4 10/24/18, 13:04