Review main Merged

58696[BUGFIX] Allow editing of pages with language ID > 9

Daniel Goerz CR +2 V +2 Easy +1 −1 updated 10/27/18, 10:15

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1112

  1. Daniel Goerz uploaded patch set 1 10/25/18, 10:50

  2. Markus Klein voted on patch set 1 V +1 CR +1 10/25/18, 11:01

  3. TYPO3com voted on patch set 1 V +1 10/25/18, 11:05 Completed build in 13m 59s on Thu, 25 Oct, 01:04 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29555

  4. Susi Moog voted on patch set 1 V +1 CR +1 10/25/18, 11:26

  5. Markus Klein voted on patch set 1 V +2 CR +2 10/25/18, 11:26

  6. Markus Klein merged patch set 2 10/25/18, 11:26

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 10/25/18, 12:23

  8. Christian Kuhn commented on patch set 2 10/25/18, 12:24

    good catch
  9. Christian Kuhn commented on patch set 2 10/25/18, 12:37

    actually, that's probably broken since $this->databaseRow['sys_language_uid'] is at least *sometimes* an array.
  10. Christian Kuhn commented on patch set 2 10/25/18, 14:04

    this is broken. we'll have two patches to solve that differently.
  11. Daniel Goerz commented on patch set 2 10/25/18, 14:14

    First one to respect arrays as well here: https://review.typo3.org/#/c/58700/
  12. Daniel Goerz commented on patch set 2 10/27/18, 10:15

    Second one to set the overrideVals everywhere: https://review.typo3.org/#/c/58712/