58700[BUGFIX] Also process array in InputSlugElement
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Oliver Hader +1
- Susi Moog +1
-
Verified V +2
- Anja Leichsenring +2
- Joerg Kummer +1
- Oliver Hader +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 2227
Show 12 earlier messages
-
Daniel Goerz uploaded patch set 1 10/25/18, 14:12
-
TYPO3com voted on patch set 1 V +1 10/25/18, 14:23 Completed build in 11m 04s on Thu, 25 Oct, 04:23 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29564
-
Christian Kuhn voted on patch set 1 V +1 CR +1 10/25/18, 18:42
-
Jigal van Hemert commented on patch set 1 10/25/18, 20:35
-
Markus Klein commented on patch set 1 10/25/18, 20:40
InputSlugElement.php:79Replywhile it might work, I consider this less readable -
Markus Klein commented on patch set 1 CR -1 10/25/18, 20:43
InputSlugElement.php:79ReplyThis is not notice free anymore if the language field does not exist at all! -
Daniel Goerz uploaded patch set 2 10/26/18, 08:51
-
TYPO3com voted on patch set 2 V +1 10/26/18, 09:05 Completed build in 13m 35s on Fri, 26 Oct, 11:05 AM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29578
-
Jörg Bösche commented on patch set 2 CR -1 10/26/18, 10:04
InputSlugElement.php:82I do prefer $languageId = 0 as default variable, instead of define it in the else-case. $languageId = 0 if(isset ....) { // override the variable } -
Daniel Goerz uploaded patch set 3 10/26/18, 10:21
-
TYPO3com voted on patch set 3 V +1 10/26/18, 10:33 Completed build in 11m 47s on Fri, 26 Oct, 12:33 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29587
-
Jürgen Heym voted on patch set 3 V +1 CR +1 10/26/18, 12:41
-
Jürgen Heym commented on patch set 3 10/27/18, 09:36
> Patch Set 3: Verified+1 Code-Review+1 This patch solves also the following problem arising with IntroPackage: 0) Language 1 is Danish, language 2 is German 1) Activate German language in SiteConfiguration 2) Creating the German translation of any page shows error: "Language 1 does not exist on site t3cms" -
Joerg Kummer voted on patch set 3 V +1 CR +1 10/27/18, 09:54
-
Susi Moog voted on patch set 3 V +1 CR +1 10/27/18, 10:17
-
Anja Leichsenring commented on patch set 3 CR -1 10/27/18, 10:42
1. the ticket assigned is for a different issue 2. the commit message does not tell me the situation when this can happen 3. I really like to get a test -
Joerg Kummer commented on patch set 3 10/27/18, 11:30
I reproduced and tested with related issue #86554 -
Anja Leichsenring updated the commit message in patch set 4 10/27/18, 11:53
-
Susi Moog updated the commit message in patch set 5 10/27/18, 11:55
-
Susi Moog voted on patch set 5 V +1 CR +1 10/27/18, 12:03
-
TYPO3com voted on patch set 4 V +1 10/27/18, 12:06 Completed build in 12m 25s on Sat, 27 Oct, 02:06 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29659
-
TYPO3com voted on patch set 5 V +1 10/27/18, 12:15 Completed build in 17m 52s on Sat, 27 Oct, 02:15 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29661
-
Oliver Hader voted on patch set 5 CR +1 10/27/18, 15:15
-
Oliver Hader voted on patch set 5 V +1 10/27/18, 15:26
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 10/27/18, 16:07
-
Anja Leichsenring merged patch set 6 10/27/18, 16:08
-
Joerg Kummer voted on patch set 6 V +1 10/27/18, 16:11
InputSlugElement.php:79