58703[BUGFIX] Properly mock LocalizationFactory in form tests
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Christian Kuhn +1
-
Verified V +2
- Markus Klein +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/form/Tests/Unit/Service/Fixtures/de.locallang_form.phpnew+26 −0
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_additional_text.phpnew+22 −0
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_ceuid_suffix_01.phpnew+47 −0
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_ceuid_suffix_02.phpnew+87 −0
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_form.phpnew+135 −0
- typo3/sysext/form/Tests/Unit/Service/Fixtures/locallang_text.phpnew+103 −0
- typo3/sysext/form/Tests/Unit/Service/TranslationServiceTest.php+24 −0
Review log 45
-
Susi Moog uploaded patch set 1 10/25/18, 18:51
-
TYPO3com voted on patch set 1 V +1 10/25/18, 19:01 Completed build in 10m 17s on Thu, 25 Oct, 09:01 PM Test Summary: 37819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29571
-
Christian Kuhn voted on patch set 1 V +1 CR +1 10/25/18, 19:33
-
Markus Klein commented on patch set 1 V +2 CR +2 10/25/18, 20:39
not much to test manually here. bamboo likes it too -
Markus Klein merged patch set 2 10/25/18, 20:39