Review TYPO3_8-7 Merged

58711[BUGFIX] Fix the extbase CoreCommand with lowest requirements

Oliver Klee CR +2 V +2 Easy +3 −1 updated 10/28/18, 13:07

Commit message

The extbase CoreCommand class calls a method that was introduced in
symfony/console 3.2. So the CoreCommand class needs to check whether
the method-to-call actually exists before calling it.

This only affects the 8.7 branch as the master/9LTS branch already
requires a higher version of symfony/console, and 7.6 does not have
the class with the corresponding call yet.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Brodala +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Oliver Klee uploaded patch set 1 10/26/18, 13:11

  2. Mathias Brodala commented on patch set 1 10/26/18, 13:18

    This is basically a breaking change since the next TYPO3v8 version with this fix cannot be installed anymore if you or any other package still requires Symfony 2.7. For this reason I'd suggest to add a "method_exists()" check instead and accept the fact that the command is visible with Symfony 2.7.
  3. TYPO3com voted on patch set 1 V -1 10/26/18, 13:18 Completed build in 07m 26s on Fri, 26 Oct, 03:18 PM Test Summary: 59600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3085

  4. Oliver Klee commented on patch set 1 10/26/18, 13:41

    Okay, will do so.
  5. Oliver Klee uploaded patch set 2 10/26/18, 13:44

  6. TYPO3com voted on patch set 2 V +1 10/26/18, 13:57 Completed build in 12m 34s on Fri, 26 Oct, 03:57 PM Test Summary: 59600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3087

  7. Mathias Brodala voted on patch set 2 CR +1 10/26/18, 14:03

  8. Oliver Klee commented on patch set 2 10/27/18, 12:20

    How to test: Install the 8.7 core with Composer with --prefer-lowest and check that the called method really is not there.
  9. Susi Moog voted on patch set 2 V +1 CR +1 10/28/18, 13:06

  10. Benni Mack voted on patch set 2 V +2 CR +2 10/28/18, 13:07

  11. Benni Mack merged patch set 3 10/28/18, 13:07