Review TYPO3_8-7 Merged

58713[BUGFIX] Prevent null value being passed to hash_equals

Benni Mack CR +2 V +2 Easy +4 −3 updated 10/27/18, 09:43

Commit message

The second parameter of hash_equals must be a string but could be a
null value in the FileDumpController. It is ensured now that the
value is always a string.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 10/26/18, 13:39

  2. Oliver Klee voted on patch set 1 CR +1 10/26/18, 13:45

  3. TYPO3com voted on patch set 1 V +1 10/26/18, 13:51 Completed build in 12m 18s on Fri, 26 Oct, 03:51 PM Test Summary: 59600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3086

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/27/18, 09:43

  5. Benni Mack merged patch set 2 10/27/18, 09:43